Skip to content
This repository has been archived by the owner on Mar 16, 2019. It is now read-only.

Add PATCH support for upload on Android #147

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

cosmith
Copy link
Contributor

@cosmith cosmith commented Oct 4, 2016

Hi! Thanks for the great library.

This PR enables support for PATCH requests on Android.

I submitted the PR on the 0.9.7 branch since this feature already works perfectly on iOS, which caused us some confusion as our code didn't seem wrong but didn't work on Android...

Let me know what you think! Maybe I missed something.

@cosmith
Copy link
Contributor Author

cosmith commented Oct 4, 2016

Now that I take a look at the iOS code it looks like it is the same there (

if([[method lowercaseString] isEqualToString:@"post"] || [[method lowercaseString] isEqualToString:@"put"]) {
) so I'm not sure why it works on iOS?

@wkh237
Copy link
Owner

wkh237 commented Oct 5, 2016

Thanks for the PR, I'll add some test case for insure IOS and Android both working properly for PATCH requests : )

@wkh237 wkh237 merged commit 74ae0ce into wkh237:0.9.7 Oct 5, 2016
@cosmith
Copy link
Contributor Author

cosmith commented Oct 6, 2016

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants