This repository has been archived by the owner on Mar 16, 2019. It is now read-only.
Catch exceptions when creating constants for sd card directories #619
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
SDCardApplicationDir
constant throws sometimesNullPointerException
.Additionally
SDCardDir
andSDCardApplicationDir
are set once on module load, but external storage can be ejected, unmounted and paths could be not valid anymore later.This PR:
NullPointerException
(and other exceptions) and sets then empty path (other ideas how to handle exception are welcome) which should be handled in JS then.getSDCardDir
andgetSDCardApplicationDir
methods to get this paths when needed from JS.QUESTION TO MAINTAINERS:
I've read contributing guidelines just now when was about to create PR, should I split it to separate PRs, to bug fix and feature branches. Somehow all this PR changes could or should be merged together maybe. And this is all about Android only and not sure to do all this library testing and use dev repository.