Skip to content

Commit

Permalink
.travis.yml: Roll back to license-test-files d2035d9
Browse files Browse the repository at this point in the history
Until [1] lands, license-test-files d19d48d will break testing (by
comparing our locally-broken XML against fixed test data).  While that
change is in flight, stick with the previous, broken test data.

An alternative approach to getting a particular commit would be to use
submodules, but:

* I expect most contributors will find this approach easier to
  manipulate, because you don't have to wrap your head around
  submodules to use it.

* The full clone (needed to ensure we still get the commit we want) is
  a price paid by GitHub (hosting the clone) and Travis (pulling the
  clone).  As long as they're both willing to pay that price, it
  doesn't seem like it's worth jumping through too many hoops to be
  more efficient.

[1]: spdx#589
  • Loading branch information
wking committed Jan 22, 2018
1 parent 21054ce commit e828efe
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ matrix:
include:
- language: java
before_install:
- git clone --depth 1 https://github.com/goneall/license-test-files
- git clone --branch master https://github.com/goneall/license-test-files
- git -C license-test-files checkout d2035d9c5327e4acbde7b3d8b24501f9d5ac6438
script:
- make TEST_DATA=license-test-files/simpleTestForGenerator validate-canonical-match
- language: node_js
Expand Down

0 comments on commit e828efe

Please sign in to comment.