Skip to content

Commit

Permalink
modules/installation-mirror-repository: Drop unnecessary 'export'
Browse files Browse the repository at this point in the history
The export landed with the module in ced98c6 (osdocs-626 preparing
for disconnected installation, 2019-08-26, openshift#16678).  But these are
local variables that we expand when calling the mirror command.  The
mirror command receives them from its command line arguments; we don't
need export [1] to expose them in the mirror command's environment as
well.

[1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#export
  • Loading branch information
wking committed May 11, 2020
1 parent 4abd206 commit 857f320
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions modules/installation-mirror-repository.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@ to determine the version of {product-title} that you want to install and determi
. Set the required environment variables:
+
----
$ export OCP_RELEASE=<release_version> <1>
$ export LOCAL_REGISTRY='<local_registry_host_name>:<local_registry_host_port>' <2>
$ export LOCAL_REPOSITORY='<repository_name>' <3>
$ export PRODUCT_REPO='openshift-release-dev' <4>
$ export LOCAL_SECRET_JSON='<path_to_pull_secret>' <5>
$ export RELEASE_NAME="ocp-release" <6>
$ OCP_RELEASE=<release_version> <1>
$ LOCAL_REGISTRY='<local_registry_host_name>:<local_registry_host_port>' <2>
$ LOCAL_REPOSITORY='<repository_name>' <3>
$ PRODUCT_REPO='openshift-release-dev' <4>
$ LOCAL_SECRET_JSON='<path_to_pull_secret>' <5>
$ RELEASE_NAME="ocp-release" <6>
----
<1> For `<release_version>`, specify the tag that corresponds to the version of {product-title} to
install for your architecture, such as `4.4.0-x86_64`.
Expand Down

0 comments on commit 857f320

Please sign in to comment.