Skip to content

Commit

Permalink
data/aws/vpc/master-elb: Set thresholds back to two
Browse files Browse the repository at this point in the history
These were changes from two to three in 16dfbb3 (data/aws: use nlbs
instead of elbs, 2019-11-01, openshift#594):

  $ git show 16dfbb3 | grep _threshold | sort | uniq
  -    healthy_threshold   = 2
  -  #   healthy_threshold   = 2
  +    healthy_threshold   = 3
  -    unhealthy_threshold = 2
  -  #   unhealthy_threshold = 2
  +    unhealthy_threshold = 3

Alex doesn't remember intentionally making that change, and the lower
thresholds will hopefully help mitigate some issues with continued
connection attempts to API servers which are in the process of
shutting down.
  • Loading branch information
wking committed Apr 16, 2019
1 parent 5a3c57c commit da1d821
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions data/data/aws/vpc/master-elb.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ resource "aws_lb_target_group" "api_internal" {
), var.tags)}"

health_check {
healthy_threshold = 3
unhealthy_threshold = 3
healthy_threshold = 2
unhealthy_threshold = 2
interval = 10
port = 6443
protocol = "HTTPS"
Expand All @@ -63,8 +63,8 @@ resource "aws_lb_target_group" "api_external" {
), var.tags)}"

health_check {
healthy_threshold = 3
unhealthy_threshold = 3
healthy_threshold = 2
unhealthy_threshold = 2
interval = 10
port = 6443
protocol = "HTTPS"
Expand All @@ -85,8 +85,8 @@ resource "aws_lb_target_group" "services" {
), var.tags)}"

health_check {
healthy_threshold = 3
unhealthy_threshold = 3
healthy_threshold = 2
unhealthy_threshold = 2
interval = 10
port = 22623
protocol = "HTTPS"
Expand Down

0 comments on commit da1d821

Please sign in to comment.