This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
feat: add wopi validator helper command #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkloucek
reviewed
Nov 28, 2023
pkg/wopivalidatorhelper/start.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| return nil |
There was a problem hiding this comment.
With the file in place, you now can call app.GatewayAPIClient.OpenInApp(...)
It's the cs3api equivalent of the /app/open call in the bash setup.
There was a problem hiding this comment.
Yes. Already doing this.....
DeepDiver1975
force-pushed
the
feat/wopi-validator-helper
branch
3 times, most recently
from
6287eef
to
24fd059
Compare
DeepDiver1975
force-pushed
the
feat/wopi-validator-helper
branch
from
24fd059
to
ac27a21
Compare
|
adding command arguments |
DeepDiver1975
force-pushed
the
feat/wopi-validator-helper
branch
from
ac27a21
to
4e07adc
Compare
DeepDiver1975
force-pushed
the
feat/wopi-validator-helper
branch
from
a8cd7f0
to
f3c4db3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This command does:
test.wopitestto the give userOpenInAppAPIFor ci integration we most probably cannot run the docker image - will be taken care of once we are there ....
Supporting testgroup argument