Pull request for issue #161 and #162 #199

aljana · 2012-05-28T00:31:15Z

The most basic wall with input box and post listing. Not finished yet but so that you can see we are moving forward. Ideas welcome. :)

…uery library that nicely resize form. I Also created a basic template for listing posts - html content is only temporary and it will be replaced with javascript generated content

mitar · 2012-05-29T21:33:24Z

Please merge with main repository.

mitar · 2012-05-29T21:39:23Z

piplmesh/frontend/static/piplmesh/css/style.css

+    border: none;
+    outline: none;
+    resize: none;
+    font-family: Verdana, Arial, Helvetica, sans-serif;


No spaces between commas?

I removed that line, we don't need different font for the textarea...

mitar · 2012-05-29T21:57:45Z

OK, I don't know how to comment on this. Yes, it looks good. But it is a bit messy. Maybe first let us get all features in and then clean the code, no?

So we need post updates to all clients connected to the page. This is still missing. Otherwise it looks nice.

mitar · 2012-05-29T21:58:20Z

But you really have to update to latest version. It also uses newer version of our tastypie library with many bugfixes.

mitar · 2012-05-31T15:11:22Z

piplmesh/frontend/static/piplmesh/js/home.js

+function generate_post_html(data) {
+    var li = $('<li/>').prop();
+
+    return '<li class="post"><span class="author">'+ data.author['username'] + '</span><p class="content">' + data.message + '</p><span class="date">'+ format_post_date(data.created_time) +'</span></li>'


Create HTML elements through jQuery.

mitar · 2012-06-01T07:02:31Z

Just to make sure, I am waiting for you here, no?

mitar · 2012-09-05T01:30:10Z

So the dates work for you now? Do you know what was wrong? Why you had problems with them?

aljana · 2012-09-05T14:57:25Z

The translations for dates and time diff calculations are now working fine. Translations started working after merging with upstream so I'm not sure what exactly was the problem.

mitar · 2012-09-05T16:38:13Z

In which way translations didn't work for you? So the only problem I noticed (after you did translations right) was that because of timezones, calculated delta was always negative between current time and post time, so "right now" was always displayed. (Probably you had some other time-span displayed, so some other time offset, because you are in the other timezone.) So when you write "does not work", you should explain how it does not work for you.

aljana · 2012-09-05T16:46:37Z

Yes I also noticed the problem with timezones and I fixed it. The other problem was that I wasn't getting Slovenian translations for "days, hours, minutes". Maybe it was cache. I don't know anymore.
Everything should be fine now. You can check. (I hope that's the last round).

mitar · 2012-09-05T16:48:19Z

It looks good now. I am still missing that you open tickets and pull requests. :-)

mitar · 2012-09-05T16:51:37Z

piplmesh/frontend/static/piplmesh/js/home.js

+                delete_link
+            );
+
+        var post = $('<li/>')


Better, but a bit too much now. :-0

var post = $('<li/>').addClass('post').data('post', self).append( post_options ).append( $('<span/>').addClass('author').text(self.author.username) ).append( $('<p/>').addClass('content').text(self.message) ).append( $('<span/>').addClass('date').text(formatPostDate(self.created_time)) );

mitar · 2012-09-05T16:55:08Z

So, do you remember which tickets we talked to open? Because I don't. :-)

aljana · 2012-09-05T17:21:45Z

Let me check.
As I understood the most important was the one with post creation multicast or something like that. So we don't send updates in the middle of request. It's described here #199 (comment). I think you should open this one, it's difficult to describe.
Other features are already written in TODOs like improving date updates and adding options (such as delete, edit) to post.

mitar · 2012-09-05T18:06:02Z

You can open tickets for important TODOs so that your colleagues can easier find it. Maybe just the one for dates.

aljana · 2012-09-05T18:26:49Z

Hmm I made a pull request for tastypie and now also all your and my comments appeared there? Didn't think of that. Should I delete them or is it okay to leave them?

mitar · 2012-09-05T18:34:12Z

I don't see them.

mitar · 2012-09-05T19:03:19Z

OK. I see them. He he. Leave. :-)

mitar · 2012-09-05T20:35:06Z

Where are other pull requests?

mitar · 2012-09-05T20:35:17Z

Please link them all here.

aljana · 2012-09-05T21:43:20Z

Ticket:

Wall post - date should be updated as time progresses #276

Pull requests:

mitar · 2012-09-05T22:20:32Z

Good job!

Pull request for issue #161 and #162

mitar · 2012-09-06T04:39:08Z

See changes I did after merge.

mitar · 2012-09-18T06:32:58Z

Oh. Was this pull request a hidden mine. It is not good to just so upgrade dependencies to newest versions (and even unreleased ones). Things completely broke. Which would be quite obvious if would run the tests. Or, if you would run the tests. Even if we do not have many of them, they fail loudly.

aljana · 2012-09-18T22:44:07Z

Hmmm where exactly is the problem? Forgot about tests... :/

mitar · 2012-09-18T22:50:24Z

I fixed the problem by reverting to older versions. But simply, mongoengine in newer versions works a bit differently, so things fail. And tastypie changed API, so things fail fast and REST protocol do not work for subresources (like comments, attachments).

So the problem is when you change requirements, then you have to test if everything still works. This is why we have concrete versions hard-coded. For all modules.

aljana · 2012-09-18T23:02:09Z

Uhh that's not good. I'm sorry about that, I completely forgot about the tests, will know better next time. But this will have to be fixed once or we'll just stick to this versions forever?

mitar · 2012-09-19T00:51:50Z

I have also forgot about tests. This is why I have now integrated the repository with Travis CI. It will check automatically every time.

Yes, we will have to fix it. But this can be a ticket or another branch/pull request, not that we have broken code and everything does not work anymore in master, where others are working on it.

Matic and others added 14 commits May 24, 2012 20:24

Some js code.

4772d14

Created a form for posting new posts, added a bit javascript and a jq…

d9d4c28

…uery library that nicely resize form. I Also created a basic template for listing posts - html content is only temporary and it will be replaced with javascript generated content

Changed color values in CSS to uppercase.

773e05f

Merged with upstream.

5841756

Js code for posting and displaying posts.

252a696

Added some animation (fadeIn) when displaying post.

1f1c570

Start of time diff function and some minor fixes.

8b24a35

Added more javascript - date formating and refactored code a bit

13e13a0

Removed temporary template for posts.

08a80bb

Added spaces around anonymous functions.

82f8cae

Small cosmetic fixes.

e98be49

Loading more posts when you scrool to the bottom of the page...

cb0f0a0

Loading of pos

0692937

Earlier and this commit is bug fixing.

53640ad

mitar reviewed May 29, 2012
View reviewed changes

Matic added 3 commits May 30, 2012 09:50

Merge with main repo.

8540654

Added some TODOs

2d0ae68

Added some TODOs

e714355

mitar reviewed May 31, 2012
View reviewed changes

Html is now created through jquery.

71ea1e0

Matic and others added 5 commits September 5, 2012 11:46

typos and 775-> 644

376a3ec

Disable submit button after being clicked.

7c6d163

Small fixes.

6eb46f6

Changed requirements and some other small issues.

fd9b0f3

Updated requirements.

0997891

mitar reviewed Sep 5, 2012
View reviewed changes

Fixed wrapping.

fcaf3ed

mitar added a commit that referenced this pull request Sep 6, 2012

Merge pull request #199 from mmiha/issue-161-164

ca65b44

Pull request for issue #161 and #162

mitar merged commit ca65b44 into wlanslovenija:master Sep 6, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pull request for issue #161 and #162 #199

Pull request for issue #161 and #162 #199

aljana commented May 28, 2012

mitar commented May 29, 2012

mitar May 29, 2012

mitar Jun 1, 2012

mitar Aug 13, 2012

aljana Aug 15, 2012

mitar commented May 29, 2012

mitar commented May 29, 2012

mitar May 31, 2012

aljana Jun 1, 2012

mitar commented Jun 1, 2012

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar Sep 5, 2012

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar commented Sep 6, 2012

mitar commented Sep 18, 2012

aljana commented Sep 18, 2012

mitar commented Sep 18, 2012

aljana commented Sep 18, 2012

mitar commented Sep 19, 2012

Pull request for issue #161 and #162 #199

Pull request for issue #161 and #162 #199

Conversation

aljana commented May 28, 2012

mitar commented May 29, 2012

mitar May 29, 2012

Choose a reason for hiding this comment

mitar Jun 1, 2012

Choose a reason for hiding this comment

mitar Aug 13, 2012

Choose a reason for hiding this comment

aljana Aug 15, 2012

Choose a reason for hiding this comment

mitar commented May 29, 2012

mitar commented May 29, 2012

mitar May 31, 2012

Choose a reason for hiding this comment

aljana Jun 1, 2012

Choose a reason for hiding this comment

mitar commented Jun 1, 2012

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar Sep 5, 2012

Choose a reason for hiding this comment

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar commented Sep 5, 2012

aljana commented Sep 5, 2012

mitar commented Sep 5, 2012

mitar commented Sep 6, 2012

mitar commented Sep 18, 2012

aljana commented Sep 18, 2012

mitar commented Sep 18, 2012

aljana commented Sep 18, 2012

mitar commented Sep 19, 2012