This repository has been archived by the owner on Jan 8, 2021. It is now read-only.
Added OpenStreetMap layer to map (#215) #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,5 +1,7 @@ | |||
| $(document).ready(function () { | |||
| var element = document.getElementById('map_canvas'); | |||
There was a problem hiding this comment.
Why do you need this variable? You are using it only once? And you can use jQuery syntax.
| var nodeName = $('<p/>').text(node.name).append(' | '); | ||
| var nodeWebsite = $('<a/>').prop('href', node.url).text(gettext("more info")); | ||
| var nodeWebsite = $('<a/>').prop('href', node.url).text(gettext('more info')); |
There was a problem hiding this comment.
No, user exposed strings we have in ". That's the main difference. The idea is that you can fast search for all strings which are visible to users. And other strings which are used internally.
|
Added TODO, switched default layer and fixed quotes |
mitar
added a commit
that referenced
this pull request
Sep 27, 2012
Added OpenStreetMap layer to map (#215)
|
I cleaned code a bit. Check what I changed. |
|
Changes reviewed :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#215