Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mqtt Broker limition of 32 character #3353

Closed
1 task done
dosipod opened this issue Sep 1, 2023 · 5 comments · Fixed by #3354
Closed
1 task done

Mqtt Broker limition of 32 character #3353

dosipod opened this issue Sep 1, 2023 · 5 comments · Fixed by #3354

Comments

@dosipod
Copy link
Contributor

dosipod commented Sep 1, 2023

What happened?

As per the original post in discord ( we are only posting as asked ) we have tested with some of the free sites and Mqtt Brokers larger then 32 character will not be allowed in wled sync page

Original post :
https://discord.com/channels/473448917040758787/473449548279185408/1146929775798136842
Broker tested is HiveMq which works fine with other mqtt clients

To Reproduce Bug

Enter more then 32 char in Mqtt Broker address

Expected Behavior

More then 32 should be allowed ( the site we tested needed 51 char but could be more in the future )

Install Method

Self-Compiled

What version of WLED?

14.0.b4

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dosipod dosipod added the bug label Sep 1, 2023
blazoncek added a commit that referenced this issue Sep 1, 2023
- for max server name length
- for max topic length

Fix for #3353
@blazoncek blazoncek linked a pull request Sep 1, 2023 that will close this issue
Aircoookie pushed a commit that referenced this issue Sep 1, 2023
- for max server name length
- for max topic length

Fix for #3353
@dosipod
Copy link
Contributor Author

dosipod commented Sep 2, 2023

Why the rush to close , could at least wait to test but i guess

@blazoncek
Copy link
Collaborator

It was closed automatically as it was linked to PR.
You can always re-open if you wish.

@dosipod
Copy link
Contributor Author

dosipod commented Sep 2, 2023

No worries , i am just not sure how to test it which i wanted to add result here or to the PR , there is a compile flag now ?

@blazoncek
Copy link
Collaborator

If you don't disable MQTT then add -D MQTT_MAX_SERVER_LEN=64 and if topic length is giving you griefs then -D MQTT_MAX_TOPIC_LEN=128 will help you out.

@dosipod
Copy link
Contributor Author

dosipod commented Sep 3, 2023

Sure you mean help the guy who uses that free site site :) as i am only testing to help you out debug this I did try 54 before but not 64 or MQTT_MAX_TOPIC_LEN=128
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants