Virtual bus size is limited to MAX_LEDS_PER_BUS

[DedeHai]

What happened?

in the UI when adding a virtual bus like DDP the maximum length is also limited to MAX_LEDS_PER_BUS. If there is no technical reason for this limit, it should not apply.

To Reproduce Bug

Add a DDP output, set size larger than 2048 (ESP32)

Expected Behavior

It should be limited to the technical limit of a virtual bus.

Install Method

Self-Compiled

What version of WLED?

nightly as well as 0.15

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

Anything else?

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[blazoncek]

That was a design choice (performance and complexity).

EDIT: Changed "is" to "was".

[netmindz]

That is a design choice (performance and complexity).

I'm sure we all appreciate that the more pixels you push, potentially the slower the frame rate etc, so "performance" doesn't seem like a reason for this restriction

Please provide a longer explanation. What complexity does it add?

I would however agree that virtual buses are still a bus, so not entirely surprising that the bus length is limited by this value

[DedeHai]

That is a design choice (performance and complexity).

I opened this issue because when I did ask, you said there was no such limit, so I assumed it was unintentional and therefore a bug.
If it is ententional, this can be closed.

[blazoncek]

Ah, my English... "was" instead of "is".

Still, networking buffers may require some RAM, that was not accounted for. Enjoy experimenting!

[DedeHai]

don't fix if it ain't broke ;)

[netmindz]

For physical buses, while in theory the length could be infinite (subject to memory), you should really be splitting out over multiple pins for better frame rate, the same is not true for virtual, so I would be in favor of excluding virtual from this limit if the reason for the limit was to encourage parallel output for high physical pixel counts

[blazoncek]

FYI the restrictions are purely UI thing.

[blazoncek]

@DedeHai you can cherry-pick from my fork if you wish.