Swap all build to V4 #4746
Closed
Swap all build to V4 #4746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This line wasn't the causing the problem I'm chasing ...
Apparently the C3 can not convert negative floats to uint8_t directly, casting it into an int first fixes it.
avoid holes by using drawLine when there is a gap
experimental
Only matripix is not working correctly on arc. Effect starts at the end of the strip and use gPC to fill to beginning.
preset loading was always resetting errorFlag to NO_ERROR. Changed so only preset-related error are reset.
* limit drift, so we don't drift away too far * added "show Center" = small crosshair * added soft blur (faster) and strong blur (slower)
Expand1D Arc - No holes, and filling the complete panel
with fix for missing pixel on 8x32 and similar ratios.
speedup for 1D->2D mapping
actually its just a minor speedup, at least with -O2
Only use palette math when text with color gradient is needed
always redraw background for each frame
scrolling text - FPS with 3 digitis colored bursts - apply gamma correction when fading
the "smooth" variant was sometimes producing XY positions outside the canvas.
Fix for LED and Scenes uncontrollable using Alexa. Weird behavior regarding to the device names and shared scenes fixed with this. Seen in issue Aircoookie/Espalexa#228 and fixed from @ams-hh Tested by myself and works just fine. Created second pull request here because the library seems to be a bit different from the official Espalexa repo. --------- Co-authored-by: Frank <91616163+softhack007@users.noreply.github.com> Co-authored-by: Blaz Kristan <blaz@kristan-sp.si>
alternative fix for wled#4228
similar to -ffast-math, but still supports NaN and infinites (needed for sunrise/sunset calculations) 10%-20% faster on -S3
* use a more meaningful max universes limit of 112 (safe up to 128x128 pixels) * accept more universes, but only track sequences for the configures max universes * made e131LastSequenceNumber[] local (its only used in e131.cpp)
* move "progress()" into FX.h so the compiler can inline it * removed redundant checks in currentBri()
Seems like a 10 microsecond delay on boards like the ESP32-P4 may not be enough, causing some issues with UDP audio sync being delayed or appearing "buffered". Oddly 10 microseconds was fine with the ESP32 and ESP32-S3, so it may also be an underlying IDF v5.3 change. Practically, 10 microseconds or 100 microseconds isn't a real difference when we're dealing in frames per second.
* isValid() -> isOk() * removed unneeded "lastBus != nullptr" checks * re-enable lastBus optimization in getPixelColor() and getPixelColorRestored() * remove duplicate checks for _valid== true from busses (already done at BusManager level)
* use bitmask operations in getBitFromArray, setBitInArray * make currentBri "const"
fix for a corner case that might lead to unexpected math overflow
* moving color_blend, color_add, and color_fade to a seperate file, to allow the compiler to inline the functions. * inlining slightly increases firmware size - original non-inline functions get used on 8266, or when WLEDMM_SAVE_FLASH is defined.
Art-Net Improvements and Other Fixes
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis update delivers a major refactor and feature expansion across the codebase, introducing new usermods, optimizing 2D LED matrix and segment handling, and adding support for additional hardware (e.g., HUB75 matrices, new ESP32 boards). Core LED and color manipulation code is optimized for ESP32 fast path builds, and memory management is improved. Several usermods are added or refactored, while some legacy or redundant usermods and documentation are removed. The build system, configuration, and documentation are updated to reflect the MoonModules fork and new licensing under EUPL-1.2. Changes
Possibly related PRs
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all builds to be using the V4 ESP-IDF, no more V3
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor
Style
Chores
Tests
Revert