Add C6 support to the ESP-IDF V5 builds

[netmindz]

C6 needs the newer ESP-IDF, so have one branch for those changes and keep this one just for the C6 specific things

Building on top of V5

Inspired by C6 Experiments

Edit (softhack007): espressif has "silently" changed a lot of APIs, and - in many cases - replacements are not behaving the same way as before. We are lucky that a few "legacy APIs" are still available, like the "V4" I2S driver. So even when "it compiles", there may be a lot more adaptations needed before "it really works".

Helpful information and migration guidance

• https://docs.espressif.com/projects/esp-idf/en/stable/esp32/migration-guides/release-5.x/5.0/peripherals.html
• https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-reference
• https://randomnerdtutorials.com/esp32-migrating-version-2-to-3-arduino/#adc-removed-apis

coding guides

We should make sure that the "V5" branch will still compile for "V4" as a backup solution.
When adding code that only works in the new framework, it should be conditionally compiled, like in the examples below

• "V5" code only for esp32-P4 or esp32-C6:

 #if defined(CONFIG_IDF_TARGET_ESP32C6)
    // https://docs.espressif.com/projects/esp-idf/en/latest/esp32c6/api-reference/peripherals/gpio.html
    // strapping pins: 4, 5, 8, 9
    if (gpio > 11 && gpio < 14) return false;     // 12-13 USB-JTAG
    if (gpio > 23 && gpio < 31) return false;     // 24-30 SPI FLASH
#elif defined(CONFIG_IDF_TARGET_ESP32P4)
    // strapping pins: 34,35,36,37,38
    if (             gpio <   2) return false;     // NC
    if (gpio > 13 && gpio <  20) return false;     // ESP-Hosted WiFi pins
    if (gpio > 23 && gpio <  26) return false;     // USB Pins
#elif defined(CONFIG_IDF_TARGET_ESP32S3)
  // .... existing code
#else
  // .... existing code
#endif

• "V5" code that is not specific to new boards

      #if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 0, 0)
      ledcAttach(pwmPin, 25000, 8);  // New API: ledcAttach(pin, freq, resolution)
      #else
      ledcSetup(pwmChannel, 25000, 8);
      // attach the channel to the GPIO to be controlled
      ledcAttachPin(pwmPin, pwmChannel);
      #endif

related

• ESP-IDF V5 #4838
• C6 experiments - C6 experiments MoonModules/WLED-MM#138
• Matter support #2871
• ESP32-C6 Support & FastLED Update to 3.9.14 #4626
• ESP-IDF-V5 MoonModules/WLED-MM#262
• P4 support - https://github.com/troyhacks/WLED/tree/P4_experimental

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch V5-C6

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[netmindz]

TODO: revert before merge, here to save CI build time

[netmindz]

@softhack007 I've started trying to cherry-pick your changes over, quite a few don't apply due to the changes with MM, but I'll try and resolve the merge conflicts for those that are simple

[softhack007]

There is one important flag for -C6 and possibly other "V5" builds, too:

  -DESP32_ARDUINO_NO_RGB_BUILTIN ;; avoids RMT driver abort on startup "E (98) rmt(legacy): CONFLICT! driver_ng is not allowed to be used with the legacy driver"

This flag disables the builtin rbg led driver of arduino-esp32. Without it, some boards will crash on boot.

[netmindz]

Thanks for the heads up

[softhack007]

@softhack007 I've started trying to cherry-pick your changes over, quite a few don't apply due to the changes with MM, but I'll try and resolve the merge conflicts for those that are simple

@netmindz thanks, I'll try to help once I'm finished with some open ends in WLED-MM 😁 december

[netmindz]

Possibly also worth looking at #4626 to see if there are any changes there that are helpful

[softhack007]

@netmindz and all,

please keep in mind that there is another "open end" for moving to ESP-IDF V5:
--> The ledc API has changed, and its not compatible with the previous "V4" API. This means we need to adapt the "analog LEDs" PWM driver, to make it work with V5.

Most likely we'll need some more #if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 0, 0) conditional code in the BusPWM driver. 🤔 Unless we completely drop PWM "analog" support in V5 builds, but I think this is not an option.

Edit: more information is here:

• https://docs.espressif.com/projects/esp-idf/en/stable/esp32/migration-guides/release-5.x/5.0/peripherals.html
• https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-reference/peripherals/ledc.html
• https://randomnerdtutorials.com/esp32-migrating-version-2-to-3-arduino/#ledc-removed-api

[netmindz]

@netmindz and all,

please keep in mind that there is another "open end" for moving to ESP-IDF V5: --> The ledc API has changed, and its not compatible with the previous "V4" API. This means we need to adapt the "analog LEDs" PWM driver, to make it work with V5.

Most likely we'll need some more #if ESP_IDF_VERSION >= ESP_IDF_VERSION_VAL(5, 0, 0) conditional code in the BusPWM driver. 🤔 Unless we completely drop PWM "analog" support in V5 builds, but I think this is not an option.

That is generic to V5 rather than being specific to C6 isn't it, so would be part of the other PR

[softhack007]

That is generic to V5 rather than being specific to C6 isn't it, so would be part of the other PR

I agree, this would be something to address in the generic V5 PR #4838