Skip to content

prevent file data loss due to replacing an open file handle (partial fix for #5275) #5276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
softhack007 merged 2 commits into from
Jan 5, 2026
Merged

prevent file data loss due to replacing an open file handle (partial fix for #5275) #5276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e27fe4
bufgix: prevent file data loss due to replacing an open file pointer
softhack007 Jan 5, 2026
a870474
Removed redundant check before closing the file handle
softhack007 Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion wled00/file.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ void closeFile() {
DEBUGFS_PRINT(F("Close -> "));
uint32_t s = millis();
#endif
f.close();
f.close(); // "if (f)" check is aleady done inside f.close(), and f cannot be nullptr -> no need for double checking before closing the file handle.
DEBUGFS_PRINTF("took %lu ms\n", millis() - s);
doCloseFile = false;
}
Expand Down Expand Up @@ -271,6 +271,8 @@ bool writeObjectToFile(const char* file, const char* key, const JsonDocument* co
s = millis();
#endif

if (doCloseFile) closeFile(); // This prevents the loss of file data that is still cached in the File object.

size_t pos = 0;
char fileName[129]; strncpy_P(fileName, file, 128); fileName[128] = 0; //use PROGMEM safe copy as FS.open() does not
f = WLED_FS.open(fileName, WLED_FS.exists(fileName) ? "r+" : "w+");
Expand Down