Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next release #383

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Next release #383

wants to merge 10 commits into from

Conversation

rolorogan
Copy link
Contributor

No description provided.

mushtaque12 and others added 3 commits July 13, 2022 13:41
* Adding quiet hours and days in disruptions signup page

* Fixing label for checkbox

* Updating state

* Updating state

* Updating aria labels

* Adding functionality to strip overlapping times

* Adding functionality to strip overlapping times

Co-authored-by: Mushtaque Ahmed <mushtaque.ahmed@wmca.org.uk>
* remove survey link

* fix receive spelling mistake
Co-authored-by: Restyled.io <commits@restyled.io>
Copy link

gitguardian bot commented Jan 3, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
1065342 Triggered Generic High Entropy Secret 0effaf8 .env.development View secret
1065342 Triggered Generic High Entropy Secret 0effaf8 netlify.toml View secret
1065342 Triggered Generic High Entropy Secret 0effaf8 netlify.toml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

return (
<>
<div>
<input
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

<label className="wmnds-fe-label" htmlFor={name}>
{hint}
</label>
<select
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

{/* Add quiet hours button */}
{!showHours || (QuietHours && QuietHours.length < 1) ? (
<div className="wmnds-col-1 wmnds-col-md-1-2">
<Button
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

iconRight="general-expand"
/>
)}
<Button
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

@rolorogan rolorogan requested a review from nathan-rogan January 3, 2024 14:50
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@restyled-io restyled-io bot mentioned this pull request Apr 2, 2024
rolorogan and others added 5 commits April 2, 2024 14:58
Co-authored-by: Restyled.io <commits@restyled.io>
# Conflicts:
#	package-lock.json
#	package.json
#	src/components/HeaderAndBreadCrumb.js
* upgrade packages

* fix lint issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants