-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next release #383
base: main
Are you sure you want to change the base?
Next release #383
Conversation
* Adding quiet hours and days in disruptions signup page * Fixing label for checkbox * Updating state * Updating state * Updating aria labels * Adding functionality to strip overlapping times * Adding functionality to strip overlapping times Co-authored-by: Mushtaque Ahmed <mushtaque.ahmed@wmca.org.uk>
* remove survey link * fix receive spelling mistake
Co-authored-by: Restyled.io <commits@restyled.io>
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
1065342 | Triggered | Generic High Entropy Secret | 0effaf8 | .env.development | View secret |
1065342 | Triggered | Generic High Entropy Secret | 0effaf8 | netlify.toml | View secret |
1065342 | Triggered | Generic High Entropy Secret | 0effaf8 | netlify.toml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
return ( | ||
<> | ||
<div> | ||
<input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
<label className="wmnds-fe-label" htmlFor={name}> | ||
{hint} | ||
</label> | ||
<select |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
{/* Add quiet hours button */} | ||
{!showHours || (QuietHours && QuietHours.length < 1) ? ( | ||
<div className="wmnds-col-1 wmnds-col-md-1-2"> | ||
<Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
iconRight="general-expand" | ||
/> | ||
)} | ||
<Button |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 You fixed the issue(s)! Great work.
Co-authored-by: Restyled.io <commits@restyled.io>
# Conflicts: # package-lock.json # package.json # src/components/HeaderAndBreadCrumb.js
* upgrade packages * fix lint issues
No description provided.