Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaning of PDC_MOUSE_POSITION/MOUSE_POS_REPORT ? #129

Open
Bill-Gray opened this issue Dec 10, 2021 · 2 comments
Open

Meaning of PDC_MOUSE_POSITION/MOUSE_POS_REPORT ? #129

Bill-Gray opened this issue Dec 10, 2021 · 2 comments

Comments

@Bill-Gray
Copy link
Contributor

We have flags/#defines for reporting mouse movement (PDC_MOUSE_MOVED, MOUSE_MOVED). And we have flags and #defines for 'reporting mouse position' (PDC_MOUSE_POSITION, MOUSE_POS_REPORT).

It would appear that the latter get exactly zero use, including in a spot-check of older versions of PDCurses. As best I can tell, they could be marked as "don't bother using these; they don't actually do anything".

Is this some sort of historical remnant? Or something that had a planned use that never happened, or...?

@wmcbrine
Copy link
Owner

Good question. Might ask @rexx-org. But it looks like they would be used to report mouse movements without any buttons held down, if that were implemented.

@Bill-Gray
Copy link
Contributor Author

Thank you. I've always assumed that PDC_MOUSE_MOVED and MOUSE_MOVED were reserved for reporting button-less mouse movements. That's the way it works in ncurses (on the platforms that support such movements at all), and it's how I've implemented mouse movements in my fork.

Maybe there was some intended use for PDC_MOUSE_POSITION and MOUSE_POS_REPORT. Right now, though, there's some risk of somebody using them thinking they'll actually do something. (That "someone" nearly being me recently.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants