Docker dev env #959
Docker dev env #959
Conversation
build/app/Dockerfile
Outdated
| RUN mkdir -p /usr/share/nginx/www/spenden.wikimedia.de/current/var/cache | ||
| RUN mkdir -p /usr/share/nginx/www/spenden.wikimedia.de/current/var/doctrine_proxies | ||
| RUN mkdir -p /usr/share/nginx/www/spenden.wikimedia.de/current/var/log | ||
| RUN chown -R www-data:www-data /usr/share/nginx/www/spenden.wikimedia.de/current/var |
There was a problem hiding this comment.
Why are you running these as individual commands instead of joining them with && ?
There was a problem hiding this comment.
Developed step by step and not groomed thereafter - this way clearly against the best practice.
|
Rebased on current master. @timEulitz will try it out on his machine and when he's successful, we can merge this. |
| - MYSQL_USER=fundraising | ||
| - MYSQL_PASSWORD=INSECURE PASSWORD | ||
| - MYSQL_DATABASE=fundraising | ||
| expose: |
There was a problem hiding this comment.
@wiese Is there a reason why there is no volume defined for the database? The current setup will delete all data and tables as soon as docker-compose is stopped.
There was a problem hiding this comment.
No explicit reason but I did not consider it needed so far. The container (and its volume) will be reused unless you explicitly remove it.
Mind "Where to Store Data" in https://hub.docker.com/_/mysql/
gbirke
force-pushed
the
docker-dev-env
branch
6 times, most recently
from
9af880c to
f268ff9
Compare
When running with the composer image, you need to add --ignore-platform-reqs to avoid missing dependencies
- Add working default configuration - Fix asset copy command - Use vendor fundraising-frontend-content
Travis should now use the same Makefile- based CI commands and dockerized environments as the local dev env.
|
|
|
Please beware that the README has a table of contents at its top which is manually maintained. So when changing the section headers or removing/adding/moving sections, this thing needs updating. This PR broke the TOC without anyone noticing, hence me mentioning it here, since perhaps no one was aware of the need to keep this in mind. |
|
Thank for pointing this out, I've added an npm task to autogenerate the TOC in #1221 |
No description provided.