This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Use Preact for wikipedia.de banner #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A "Hello World" banner for wikipedia.de Updated dependencies for Babel 7 Added jsx plugin Temporarily commented out our custom webpack plugins - they cause trouble (TODO).
Babel 7 and the `useBuiltIns: 'usage'` setting injects ES6 imports into the CommonJS-based banners. This leads to the error message TypeError: "exports" is read-only` in the compiled banners (See also webpack/webpack#3997 and babel/babel#6980 ). Changed `getSkin` in "BannerFunctions" to preload all skin manipulating classes.
The Application of Funds lightbox is not working - check with FR if needed
Add new component Implement banner closing (shared state at the top, passed down thrugh `bannerVisible` prop) Add className utility function to generate conditional class names in a more clean way. Fill out TODOs for using the banner on wp.org
Pass the callback to the child method up the component hierarchy, via a "trigger method", so the mobile banner can call the method for the animation when it shows the fullpage banner. Add explicitly evaluated spaces to TextHighlight child text to circumvent [JSX space-eating behavior][1]. [1]: facebook/react#4134
timEulitz
reviewed
Oct 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.