Github Actions, on PR and push (+selectivity) #317
Conversation
|
This currently doubles the number of jobs that run, which is probably not ideal. Perhaps we should only run on |
|
I still don't understand why this PR makes |
This makes CI run on PRs as well, rather than only on the underlying branches. This will lead to the PR jobs actually running with the base of the PR merged into the head. Also be more selective about when to run some jobs, so for example we can now make docs changes, without running the WHOLE build and test pipeline.
toban
force-pushed
the
ci-on-pr-and-push-and-selective
branch
from
86cbb7c to
bf1e330
Compare
|
I thought this had something to do with the git history but did a clean PR of main with these contents and it failed too https://github.com/wmde/wikibase-release-pipeline/pull/323/files |
|
The code scanning is just not currently running, (prior to this PR), so perhaps I should just remove it for now... |
It's not running in this PR you mean? I can see it ran on the last commit to main. If you wanna get rid of it completely we probably wanna remove each section of build_and_test.yml it's currently not crashing but makes not sense to keep it. |
The last commit on main for me is https://github.com/wmde/wikibase-release-pipeline/actions/runs/1921632522 and I do not see the scan? For this PR the scan was running as a totally seperate workflow
But indeed, the scan then also normally runs at the end of the other build and test workflows So I should probably add the file back. But I also guess adding the file triggers something else weird (this other workflow we see in this PR) to run sometimes? |
This reverts commit 35117ef.
|
Think I found it (maybe??) |
This makes CI run on PRs as well, rather than only on the
underlying branches.
This will lead to the PR jobs actually running with the base of
the PR merged into the head.
Also be more selective about when to run some jobs, so for example
we can now make docs changes, without running the WHOLE build and
test pipeline.