-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T350782 Test System Rewrite #542
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
lorenjohnson
commented
Dec 18, 2023
RickiJay-WMDE
requested changes
Dec 18, 2023
RickiJay-WMDE
requested changes
Dec 18, 2023
RickiJay-WMDE
requested changes
Dec 18, 2023
RickiJay-WMDE
requested changes
Dec 19, 2023
RickiJay-WMDE
requested changes
Dec 19, 2023
RickiJay-WMDE
requested changes
Dec 19, 2023
RickiJay-WMDE
approved these changes
Dec 20, 2023
lorenjohnson
added a commit
that referenced
this pull request
Dec 20, 2023
f4100de
to
0e182f7
Compare
0e182f7
to
ca721e3
Compare
lorenjohnson
added a commit
that referenced
this pull request
Dec 22, 2023
…r usage in scripts, updates test docs (#553) - Correctly uses new wikibase/* namespace when checking for already-loaded Docker Images in test - Shares test-runner setup stuff in common with the lint.sh and test.sh scripts in "test/scripts/test_runner_setup.sh" - Adds a DEBUG option for "test.sh" which will passthrough Docker build and setup stuff in the case of mysterious issues when running the script - Adds a "--command", "-c" option for "test.sh" which will allow commands to be ran on test-runner - "lint.sh" now also builds test-runner like "test.sh" did - Explicitly creates the Docker network used by test-runner and test-services when it doesn't already exist - Test documentation update
RickiJay-WMDE
pushed a commit
that referenced
this pull request
Feb 19, 2024
…r usage in scripts, updates test docs (#553) - Correctly uses new wikibase/* namespace when checking for already-loaded Docker Images in test - Shares test-runner setup stuff in common with the lint.sh and test.sh scripts in "test/scripts/test_runner_setup.sh" - Adds a DEBUG option for "test.sh" which will passthrough Docker build and setup stuff in the case of mysterious issues when running the script - Adds a "--command", "-c" option for "test.sh" which will allow commands to be ran on test-runner - "lint.sh" now also builds test-runner like "test.sh" did - Explicitly creates the Docker network used by test-runner and test-services when it doesn't already exist - Test documentation update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces PR #525 with a much more clear commit history. This branch also no longer includes linting of
docs/diagrams
or the property test updates.Makes possible running tests more atomically, and more. https://phabricator.wikimedia.org/T350782
*.conf.js
files and review the related Typescript types which self-document much of what is happening.suites/SUITE_NAME/results/wdio*.log
. Here we can see all browser console output, as well as detail results of each selector happening in each spec file. Setup log from steps before test runners start iswdio.log
, subsequent log files are created for each spec file ran according to the correlated WDIO job runner number, e.g.wdio-0-1.log
, etc.make test SUITE=<suite-name>
to./test.sh <suite-name>
--setup
test runner option to bring-up a test suites services without running tests, and leave them up along with the Selenium instance for manual testing, e.g./test.sh quickstatements --setup
./test.sh <suite-name> <WDIO-Runner-CLI-options>
. E.g../test.sh repo --spec=specs/repo/property.ts --watch
, etc./test.sh example
./test.sh upgrade WMDE9 <optional-version-tag-of-upgrade-to-version>
*_SERVER
env variables to*_URL
in the test environment (the only place we were using these variables) and adds thehttp://
protocol prefix where it wasn't consistently applied before.node_modules
directorieslint
as a "need" of thebuild
andtest
jobs . This will have the effect of the checks still failing if linting fails, butbuild
andtest
continue running and building runs in parallel with linting decreasing test run times by a couple minutes.... etc
Please try out the new Test CLI, here is the help for that which can be retrieved by simply typing
./test.sh
or./test.sh --help
:Also help is available specific to the Upgrade test suite: