Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example #668

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Update example #668

merged 1 commit into from
Apr 29, 2024

Conversation

adeeri
Copy link
Contributor

@adeeri adeeri commented Apr 25, 2024

No description provided.

@rti rti requested a review from a team April 26, 2024 06:20
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. To this point we have made this change after release so we can see tests pass, but I do understand that the Dockerhub release is being held back until a release announcement is sent.

@adeeri adeeri merged commit 4d2b529 into mw-1.39 Apr 29, 2024
26 checks passed
@adeeri adeeri deleted the post-release-1.39.7 branch April 29, 2024 08:41
rti added a commit that referenced this pull request May 16, 2024
* Set variables.env to wmde.13 values

* Test mw-* branches (#503) (#504)

* fix(github-actions): GHCR upload (#505) (#509)

* fix(github-actions): GITHUB_TOKEN access for GHCR upload

* fix(github-actions): docker image name

* chore: move if to job level

* fix: get built docker artifacts in ghcr upload job

* fix(github-actions): ghcr image name

* chore: run upload ghcr only on main and mw-?.?? branches

* fix: simplify job run check, we do not have regex here :(

* feat: upload to GHCR from prep-mw- branches as well (#514) (#516)

* fix(github-actions-workflow): ghcr upload base_ref check (#518) (#521)

* fix: gh built artifact names (#512) (#527)

* chore: update variables.env to new format

use commit hashes from WMDE.13 release CI build
https://phab.wmfusercontent.org/file/download/67e7x2izldkdqmqexnwe/PHID-FILE-atrxuifwzod3ur25xju5/BuildMetadata.zip

* fix: update test the correct versions in CI

* Release 1.39.6 (#568)

* Manually backporting formatting changes

* Revert "Releaseprep wmde.17 (#607)"

This reverts commit 090be85.

* Delete build_and_test

* Fix image urls

* Lint

* Lint

* Revert cont.

* Fix upgrade path

* Release prep

* Final release version

* Set release date

* Update example (#668)

---------

Co-authored-by: Ricki Jay <ricki.jay@wikimedia.de>
Co-authored-by: Ricki <141253288+RickiJay-WMDE@users.noreply.github.com>
Co-authored-by: adeeri <132473526+adeeri@users.noreply.github.com>
Co-authored-by: adeeri <adee.ritman@wikimedia.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants