Add optional healthcheck scripts to WBS images #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenjohnson
force-pushed
the
healthchecks-to-dockerfiles
branch
3 times, most recently
from
ccd31f5 to
2e419f1
Compare
lorenjohnson
force-pushed
the
main
branch
4 times, most recently
from
e17ecc8 to
58a3ece
Compare
rti
requested changes
Nov 7, 2024
lorenjohnson
force-pushed
the
healthchecks-to-dockerfiles
branch
from
8ed8556 to
2e419f1
Compare
lorenjohnson
force-pushed
the
healthchecks-to-dockerfiles
branch
from
2e419f1 to
9004bdb
Compare
Got it, re-applied on the current main. |
rti
reviewed
Nov 8, 2024
rti
reviewed
Nov 8, 2024
rti
approved these changes
Nov 8, 2024
rti
reviewed
Nov 8, 2024
Maybe we can now squash it again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes all in-line healthchecks specifics and puts them in a
healthcheck.shfor each image. Not applying by default in image (i.e. as aHEALTHCHECKin the Dockerfile) to keep things flexible, but gives the responsibility for how to healthcheck back to the image--which is what Docker recommends. Also removing this specific from Deploy removes one more possible change vector in the Deploy configuration, keeping things easier to maintain and upgrade for users over time. Also has the benefit of making a standard healthcheck option available for the images for use cases outside of Deploy.In a related move this adds a new
IS_JOBRUNNERoption the Wikibase image instead of changing the command/entrypoint script. This allows the same health check script to be pointed which now will also healthcheck jobrunner when used in that mode.This PR is setup with atomic conventional commits and would be best to do a regular merge vs squash.