This repository has been archived by the owner on Mar 1, 2019. It is now read-only.
Configuration code style #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let tslint check our JS (configuration) files in the project root, too. With the release of palantir/tslint#3641 (I subscribed) the manual [prototypical] re-specification of `jsRules` will hopefully be obsolte soon.
Apply rules defined for JS files.
Consistently indent JSON files. This goes against the tab indentation we do for program files but allows for configuration files modified by programs (e.g. npm using JSON.stringify() for package.json) to stay consistent in the long run.
jakobw
approved these changes
Nov 20, 2018
| ], | ||
| "lib": [ | ||
| "esnext", | ||
| "es5", | ||
| "dom", | ||
| "dom.iterable", | ||
| "scripthost" | ||
| ] | ||
| ], | ||
| "allowJs": true |
|
palantir/tslint#3641 was released in tslint 5.12.0 (comes with @vue/cli-plugin-typescript@3.2.0) - unfortunately this comment is right in that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let tslint check our JS (configuration) files in the project root, too.
With the release of palantir/tslint#3641 (I subscribed) the manual [prototypical] re-specification of
jsRuleswill hopefully be obsolte soon.Consistently indent JSON files. This goes against the tab indentation we
do for program files but allows for configuration files modified by
programs (e.g. npm using JSON.stringify() for package.json) to stay
consistent in the long run.