Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace set-output with $GITHUB_ENV in test-and-demo workflow #666

Merged
merged 1 commit into from
Dec 29, 2022
Merged

Replace set-output with $GITHUB_ENV in test-and-demo workflow #666

merged 1 commit into from
Dec 29, 2022

Conversation

guergana
Copy link
Contributor

@guergana guergana commented Dec 29, 2022 •
edited
Loading

@github-actions
Copy link

https://3d6a5ac6b9eb834ace3fe28f5f8d8502cbae381c--wmde-wikit.netlify.app

@guergana guergana force-pushed the replace-setoutput-testAndDemo branch from 7e1f7dd to 14a7ac0 Compare December 29, 2022 12:45
@guergana guergana force-pushed the replace-setoutput-testAndDemo branch from 14a7ac0 to c08e390 Compare December 29, 2022 12:54
itamargiv
itamargiv approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@itamargiv itamargiv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Works well. Thank you!

@guergana guergana merged commit 0ab1e9f into master Dec 29, 2022
@guergana guergana deleted the replace-setoutput-testAndDemo branch December 29, 2022 16:42
micgro42 pushed a commit that referenced this pull request Jan 9, 2023
@guergana @micgro42
Cherry Pick "Replace set-output with $GITHUB_ENV in test-and-demo wor…
f40071d 
…kflow (#666)"

Bug: T322548
@micgro42 micgro42 mentioned this pull request Jan 9, 2023
Merged
micgro42 added a commit that referenced this pull request Jan 9, 2023
@micgro42 @guergana
Cherry Pick commits to fix warnings on GitHub Action (#673)
0748a0b 
This collects the changes of the PRs #643, #665 and #666

Bug: T322548
Co-authored-by: Guergana Tzatchkova <guergana.tzatchkova@wikimedia.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itamargiv itamargiv itamargiv approved these changes

@chukarave chukarave Awaiting requested review from chukarave

@hasanakg hasanakg Awaiting requested review from hasanakg

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guergana @itamargiv