New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update init-letsencrypt.sh #89

Draft

pcarioufr wants to merge 3 commits into wmnnd:master from pcarioufr:patch-1

pcarioufr commented Sep 5, 2020

Thanks for this :-) 👍 It was really helpful !

I think this would help:

fix loop on domains for dummy certificates
create bigger SSH Key (4096) as 1024 would fail with current nginx version

pcarioufr added 2 commits

September 5, 2020 22:22


Update init-letsencrypt.sh

8cdb071

fix loop on domains for dummy certificates


Update init-letsencrypt.sh

40cdf45

pcarioufr marked this pull request as draft

September 5, 2020 20:48


Update init-letsencrypt.sh

77493c1

williamforster commented Oct 12, 2020

Thanks for the guide, +1 to changing ssh key to 4096, nginx does not accept key at current length

ash0080 approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment