Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table B 0 08 045 is missing #88

Closed
amilan17 opened this issue Sep 23, 2021 · 12 comments · Fixed by #95
Closed

Table B 0 08 045 is missing #88

amilan17 opened this issue Sep 23, 2021 · 12 comments · Fixed by #95
Assignees
Milestone

Comments

@amilan17
Copy link
Member

amilan17 commented Sep 23, 2021

Branch

https://github.com/wmo-im/BUFR4/tree/issue83

Summary and purpose

0 08 045 is missing. Referenced in Class 08, note 7: "When descriptor 0 08 043 is used to specify particulate matter (PM) under a given size threshold, descriptor 0 08 045 may also be used to further specify a subset of the PM population on the basis of ion composition."
page: BUFR/CREX Table B/08 - 5

Stakeholders

include as appropriate

Action proposed

Add missing reference or update note

Discussions

see comments below

Detailed proposal

  1. Change note to: "When descriptor 0 08 043 is used to specify particulate matter (PM) under a given size threshold, descriptor 0 08 044 or 0 08 046 may also be used to further specify a subset of the PM population on the basis of ion composition."
    2. Add title for table 0 08 44 in PDF
@amilan17 amilan17 assigned amilan17 and unassigned amilan17 Sep 23, 2021
@amilan17 amilan17 added this to the FT2022-1 milestone Sep 23, 2021
@amilan17
Copy link
Member Author

amilan17 commented Oct 6, 2021

@amilan17 - research previous amendments
Sergio found this descriptor in versions 13 -17 of the standard on his computer, maybe it was removed on purpose or accident?
Jeff - perhaps they note should reference 0 08 044 or 0 08 046 instead

@amilan17 amilan17 self-assigned this Oct 6, 2021
@david-i-berry
Copy link
Member

Based on https://confluence.ecmwf.int/display/ECC/WMO%3D18+element+table the last occurrence of 008045 is in version 18.

008045 8 45 PARTICULATE MATTER CHARACTERIZATION particulateMatterCharacterization CODE TABLE 0 0 8 CODE TABLE 0 3

@jbathegit
Copy link
Contributor

jbathegit commented Nov 9, 2021

0-08-044 apparently does exist, as "CAS registry number". I just checked the BUFRCREX_TableB_en.xml files for versions 35, 36, and 37, and all of them include 0-08-044 as follows:

  <BUFRCREX_TableB_en>
    <ClassNo>08</ClassNo>
    <ClassName_en>Significance qualifiers</ClassName_en>
    <FXY>008044</FXY>
    <ElementName_en>CAS registry number</ElementName_en>
    <BUFR_Unit>CCITT IA5</BUFR_Unit>
    <BUFR_Scale>0</BUFR_Scale>
    <BUFR_ReferenceValue>0</BUFR_ReferenceValue>
    <BUFR_DataWidth_Bits>88</BUFR_DataWidth_Bits>
    <CREX_Unit>Character</CREX_Unit>
    <CREX_Scale>0</CREX_Scale>
    <CREX_DataWidth_Char>11</CREX_DataWidth_Char>
    <Status>Operational</Status>
  </BUFRCREX_TableB_en>

I presume it also exists in earlier versions as well, but at this point I only just checked 35, 36, and 37.

@SibylleK
Copy link
Contributor

SibylleK commented Nov 9, 2021

It seems, that 008045 has never been validated and was finally withdrawn? Information could be found in the report of the Joint Meeting of CT-MTDCF and ET-DRC in Montreal 2006. The proposed code table was:

Code table 0 08 045
Code figure Meaning
0 Particulate Matter (all types)
1 NO3(-)
2 NH4(+)
3 Na(+)
4 Cl(-)
5 Ca(2+)
6 Mg(2+)
7 K(+)
8 SO4(2-)
9-200 reserved
201-254 reserved for local use
255 missing

But, at this time the Common Code Table C-14 does not exit and was developed only afterwards.

Therefore, the note should rather be changed in:
"When descriptor 0 08 043 is used to specify particulate matter (PM) under a given size threshold, descriptor 0 08 044 or 0 08 046 may also be used to further specify a subset of the PM population on the basis of ion composition."

@amilan17
Copy link
Member Author

amilan17 commented Nov 10, 2021

@jbathegit  ok. I assume 0 08 044 is not in this CSV below, because we can't copy the entire CAS Registry. https://github.com/wmo-im/BUFR4/blob/master/BUFRCREX_CodeFlag_en_08.csv

@jitsukoh I recommend publishing this table in the PDF in 

@amilan17
Copy link
Member Author

@SibylleK Thank you for finding this 2006 report. I see that is was also "awaiting validation" in the 2007 report and then no mention of it in the 2008 reports.

@jbathegit
Copy link
Contributor

This is interesting. I thought the XML files were generated from the CSV files, so I'm curious how 008044 is in the former but not the latter?

I guess I would have been expecting something like we have for 008046 in the CSV files, where there's just a placeholder marking that the entry is occupied, but like you said not a copy of the entire CAS registry. I agree that would be unnecessary and incredibly burdensome.

@amilan17
Copy link
Member Author

amilan17 commented Nov 10, 2021

@amilan17
Copy link
Member Author

don't put reference to 0 08 044 in section with code tables, because it's not a code table

@amilan17
Copy link
Member Author

This is interesting. I thought the XML files were generated from the CSV files, so I'm curious how 008044 is in the former but not the latter?

@jbathegit 0 08 044 is listed https://github.com/wmo-im/BUFR4/blob/master/BUFRCREX_TableB_en_08.csv and this is what the https://github.com/wmo-im/BUFR4/blob/master/xml/BUFRCREX_TableB_en.xml is generated from

amilan17 added a commit that referenced this issue Nov 11, 2021
@amilan17
Copy link
Member Author

@jitsukoh the notes file in the branch is updated and ready for validation

@jitsukoh
Copy link

@amilan17 thank you for updating. Looks good. I move this issue to the validated status.

@amilan17 amilan17 linked a pull request Dec 8, 2021 that will close this issue
@amilan17 amilan17 removed a link to a pull request Dec 8, 2021
@amilan17 amilan17 linked a pull request Dec 8, 2021 that will close this issue
amilan17 added a commit that referenced this issue Dec 21, 2021
* issue #83

* xml,txt files

* Update BUFRCREX_TableB_notes.csv

#88

Co-authored-by: Enrico Fucile <efucile@wmo.int>
@amilan17 amilan17 closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants