-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table B 0 08 045 is missing #88
Comments
@amilan17 - research previous amendments |
Based on https://confluence.ecmwf.int/display/ECC/WMO%3D18+element+table the last occurrence of 008045 is in version 18.
|
0-08-044 apparently does exist, as "CAS registry number". I just checked the BUFRCREX_TableB_en.xml files for versions 35, 36, and 37, and all of them include 0-08-044 as follows:
I presume it also exists in earlier versions as well, but at this point I only just checked 35, 36, and 37. |
It seems, that 008045 has never been validated and was finally withdrawn? Information could be found in the report of the Joint Meeting of CT-MTDCF and ET-DRC in Montreal 2006. The proposed code table was: Code table 0 08 045 But, at this time the Common Code Table C-14 does not exit and was developed only afterwards. Therefore, the note should rather be changed in: |
@jbathegit ok. I assume 0 08 044 is not in this CSV below, because we can't copy the entire CAS Registry. https://github.com/wmo-im/BUFR4/blob/master/BUFRCREX_CodeFlag_en_08.csv @jitsukoh I recommend publishing this table in the PDF in |
@SibylleK Thank you for finding this 2006 report. I see that is was also "awaiting validation" in the 2007 report and then no mention of it in the 2008 reports. |
This is interesting. I thought the XML files were generated from the CSV files, so I'm curious how 008044 is in the former but not the latter? I guess I would have been expecting something like we have for 008046 in the CSV files, where there's just a placeholder marking that the entry is occupied, but like you said not a copy of the entire CAS registry. I agree that would be unnecessary and incredibly burdensome. |
don't put reference to 0 08 044 in section with code tables, because it's not a code table |
@jbathegit 0 08 044 is listed https://github.com/wmo-im/BUFR4/blob/master/BUFRCREX_TableB_en_08.csv and this is what the https://github.com/wmo-im/BUFR4/blob/master/xml/BUFRCREX_TableB_en.xml is generated from |
@jitsukoh the notes file in the branch is updated and ready for validation |
@amilan17 thank you for updating. Looks good. I move this issue to the validated status. |
Branch
https://github.com/wmo-im/BUFR4/tree/issue83
Summary and purpose
0 08 045 is missing. Referenced in Class 08, note 7: "When descriptor 0 08 043 is used to specify particulate matter (PM) under a given size threshold, descriptor 0 08 045 may also be used to further specify a subset of the PM population on the basis of ion composition."
page: BUFR/CREX Table B/08 - 5
Stakeholders
include as appropriate
Action proposed
Add missing reference or update note
Discussions
see comments below
Detailed proposal
2. Add title for table 0 08 44 in PDFThe text was updated successfully, but these errors were encountered: