Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New BUFR template for cloud radar observations and new descriptors table B class 21 #90

Closed
marijanacrepulja opened this issue Sep 30, 2021 · 18 comments · Fixed by #101
Closed
Assignees
Milestone

Comments

@marijanacrepulja
Copy link
Collaborator

marijanacrepulja commented Sep 30, 2021

Branch

https://github.com/wmo-im/BUFR4/tree/issue90

Summary and purpose

ECMWF is proposing a new BUFR template for representation of radar observations from EarthCARE (Cloud, Aerosol and Radiation Explorer)

Stakeholders

Marijana Crepulja, Mark Fielding, Marta Janiskova (all from ECMWF)

Action proposed

The team is kindly asked to review and approve the contents for inclusion within the next update to the WMO Manual on Codes.

Discussions

ECMWF is preparing for monitoring and operational assimilation of cloud observations from EarthCARE . Therefore a new BUFR template is needed.

Detailed proposal

1. Add a new entries in the radar data class of table B

F X Y ELEMENT NAME UNIT SCALE REFERENCE VALUE DATA WITH (bits)
0 21 007 Radar reflectivity factor dB 2 -9000 15
0 21 008 Uncertainty in radar reflectivity factor dB 2 0 13
0 21 009 Vertical Doppler velocity m/s 2 -10000 15
0 21 010 Uncertainty in Vertical Doppler velocity m/s 2 -10000 15

2. Add a new entry in the Processing information class of table B (0-25-139) and a new code table to describe the Processing level

F X Y ELEMENT NAME UNIT SCALE REFERENCE VALUE DATA WITH (bits)
0-25-139 Processing level Code table 0 0 5

3. Add new CODE TABLE 0-25-139 for Processing level

Code Figure Processing level
0 L1B
1 L2A
2-30 Reserved
31 Missing

4. Add a new BUFR template for radar cloud observations

Table reference Table references Element name Description / comments
3-21-031 Satellite Radar observations
0 01 007 Satellite Identifier
0 02 019 Satellite Instruments
0 01 033 Identification of originating/generating centre
0 01 034 Identification of originating/generating sub-centre
3 01 011 Year, Month, Day
3 01 013 Hour, Minute, Second
3 01 021 Latitude/longitude (high accuracy)
0 10 033 Altitude (Platform To Ellipsoid)
0 08 043 Atmospheric chemical or physical constituent type
0 25 139 Processing level
0 02 153 Satellite channel centre frequency
1 06 000 Delayed replication of 6 elements
0 31 002 Extended delayed descriptor replication factor
0 07 071 Height (high resolution)
0 21 007 Radar reflectivity factor
0 21 008 Uncertainty in radar reflectivity factor
0 21 009 Vertical Doppler velocity
0 21 010 Uncertainty in vertical Doppler velocity
0 33 003 Quality information
@marijanacrepulja marijanacrepulja changed the title Proposal for \[XYZ\].csv New BUFR template for cloud radar observations and new descriptors table B class 21 Sep 30, 2021
@marijanacrepulja marijanacrepulja self-assigned this Sep 30, 2021
@marijanacrepulja marijanacrepulja added this to the FT2022-1 milestone Sep 30, 2021
@amilan17
Copy link
Member

ready for validation

@amilan17
Copy link
Member

@richardweedon @marianmajan-ibl @jbathegit validate with sample data

@amilan17
Copy link
Member

@marijanacrepulja double check with colleagues on the request for dBZ

@marijanacrepulja
Copy link
Collaborator Author

We agree to use dB units for Radar reflectivity factor, after consulting with my colleagues.

@marijanacrepulja
Copy link
Collaborator Author

marijanacrepulja commented Dec 2, 2021

I have updated branch with new entries.
Sample data and corresponding output of decoded BUFR file is attached

EarthCARE-CPR1B_test.zip

@richardweedon @marianmajan-ibl @jbathegit could you please help with validation.
Many thanks.

@jbathegit
Copy link
Contributor

@marijanacrepulja I've started to work on this. However, I don't see 0-25-139 defined anywhere in Table B. Is this another new proposed new Table B descriptor? If so, then could you please add it to part 1 of this proposal?

@marijanacrepulja
Copy link
Collaborator Author

@jbathegit many thanks for looking into this. Descriptor 0-25-139 is proposed in issue 91, however I added it to this issue as well, to be consistent with the branch. I have updated the branch with definition of 0-25-139. Sorry for inconvenience.

@jbathegit
Copy link
Contributor

Thanks @marijanacrepulja. With that, I was able to decode the BUFR from your zip bundle, and I spot-checked several reports and confirmed I got the same results as shown in your .txt file. So from my standpoint it's a successful validation.

amilan17 added a commit that referenced this issue Dec 8, 2021
@amilan17
Copy link
Member

amilan17 commented Dec 8, 2021

@marijanacrepulja I updated the branch to include the "Element Description" as indicated above in Table D. I also changed several words to begin with lower case, because they are not proper nouns. If you agree with these edits, please tag Jitsiku for final approval.

@amilan17
Copy link
Member

amilan17 commented Dec 8, 2021

FT22-1...issue90

@richardweedon
Copy link

Managed to decode the sample data. In addition received a positive review from our satellite applications scientists. From my perspective the review is complete.

@marianmajan-ibl
Copy link

Hello, @marijanacrepulja, I have successfully decoded your samples with the tables from the branch. However, currently the converted file is nearly 4 GB, I have added to the GDrive again -- https://drive.google.com/file/d/1zsEZg9Fl6rNDEL5Br16kUYfMuLX-LGGr/view?usp=sharing

Very quick manual check showed the same results with one exception -- it seems that we have an error when showing 0 02 153 Satellite channel centre frequency = [Hz] -- the value is empty. I will try to investigate this (but I assume it is problem of our decoding / showing results).

@marijanacrepulja
Copy link
Collaborator Author

@jbathegit, @richardweedon, @marianmajan-ibl Thanks very much for your help to validate this proposal!

@marijanacrepulja
Copy link
Collaborator Author

@marijanacrepulja I updated the branch to include the "Element Description" as indicated above in Table D. I also changed several words to begin with lower case, because they are not proper nouns. If you agree with these edits, please tag Jitsiku for final approval.

@amilan17 Many thanks for updating the branch. I agree with the modifications you've made. I removed only "L1B, L2A" from "Element Description" in the branch and the proposal, because it is only relevant to this proposal.

@marianmajan-ibl
Copy link

marianmajan-ibl commented Dec 14, 2021

I just would like to confirm that the problem with the empty value in the descriptor 0 02 153 is just a problem of output formatting in our tool, my colleague has debugged it and the value is correctly decoded as 94000000000 for the last BUFR.

@jitsukoh
Copy link

@marijanacrepulja @amilan17 in BUFR_TableD_en_21.csv and txt/BUFR_TableD_en.txt "Latitude/longitude(high accuracy)" should be "Latitude/longitude (high accuracy)" (with a space between longitude and (high)?

amilan17 added a commit that referenced this issue Dec 15, 2021
@amilan17
Copy link
Member

@jitsukoh typo is fixed.

@jitsukoh
Copy link

@amilan17 thanks! I confirm that the branch is updated and I move this issue to the validated status.

@amilan17 amilan17 linked a pull request Dec 20, 2021 that will close this issue
amilan17 added a commit that referenced this issue Dec 21, 2021
* issue #90

* xml,txt files

* issue90

* xml,txt files

* issue 90

* xml,txt files

* Update BUFRCREX_TableB_en_21.csv

Fixed typo in FXY number

* xml,txt files

* Update BUFR_TableD_en_21.csv

Fixed typo in FXY number

* xml,txt files

* Issue #90

* xml,txt files

* issue 90

* xml,txt files

* Update BUFRCREX_CodeFlag_en_25.csv

typo at line 259

* xml,txt files

* #90 fix typo

* xml,txt files

Co-authored-by: Marijana Crepulja <mamc@ecmwf.int>
Co-authored-by: Enrico Fucile <efucile@wmo.int>
Co-authored-by: Jeff Ator <62722702+jbathegit@users.noreply.github.com>
Co-authored-by: Sibylle Krebber <62389319+SibylleK@users.noreply.github.com>
@amilan17 amilan17 closed this as completed Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants