Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong reserved range for table 4.2 and "Product discipline 0 - Meteorological products, parameter category 1: moisture" #129

Closed
rouault opened this issue Dec 8, 2021 · 6 comments · Fixed by #135
Assignees
Milestone

Comments

@rouault
Copy link

rouault commented Dec 8, 2021

Branch

https://github.com/wmo-im/GRIB2/tree/issue129

Summary and purpose

In table https://raw.githubusercontent.com/wmo-im/GRIB2/master/GRIB2_CodeFlag_4_2_CodeTable_en.csv, there are the following records:

Parameter number by product discipline and parameter category,"Product discipline 0 - Meteorological products, parameter category 1: moisture",149,,Cloud water mixing ratio,,kg kg-1,Operational
Parameter number by product discipline and parameter category,"Product discipline 0 - Meteorological products, parameter category 1: moisture",149-191,,Reserved,,,Operational

The range 149-191 conflicts with the previous record

Action proposed

Change range 149-191 to 150-191

@amilan17 amilan17 added this to the FT-2022-1 milestone Dec 8, 2021
@amilan17 amilan17 self-assigned this Dec 8, 2021
@amilan17 amilan17 added the branch label Dec 8, 2021
amilan17 added a commit that referenced this issue Dec 8, 2021
@amilan17
Copy link
Member

amilan17 commented Dec 8, 2021

@jitsukoh This was a typo. Please validate the edit FT22-1...issue129

@amilan17
Copy link
Member

amilan17 commented Dec 8, 2021

@rouault Thanks for letting us know.

@jitsukoh
Copy link

@amilan17 I confirm that the CSV file was corrected and the issue is moved to the validated status.

@jitsukoh
Copy link

@amilan17 I found a "different" typo in the same table in the PDF version (I am looking at 306_I2_2019_updated 2021_en_july.pdf).
"Reserved" figures should be 150-191.
GRIB4 2-0-1
At this moment, I moved this back to in validation.

@amilan17
Copy link
Member

@jitsukoh if I understand correctly, the error in the CSV is the same as the error in the PDF. The CSV is now correct and the PDF will be corrected at the same time as the other amendments.

@jitsukoh
Copy link

@amilan17 thanks. The CSV said "149-191" but the PDF said "147-191" but the wrong part is the same. Moved to validated again.

@amilan17 amilan17 linked a pull request Dec 20, 2021 that will close this issue
amilan17 added a commit that referenced this issue Dec 21, 2021
@amilan17 amilan17 closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants