Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add template and codes tables for HEALPix grid #212

Merged
merged 3 commits into from
Aug 10, 2023
Merged

add template and codes tables for HEALPix grid #212

merged 3 commits into from
Aug 10, 2023

Conversation

amilan17
Copy link
Member

amilan17
amilan17 commented Jul 13, 2023
View reviewed changes
Copy link
Member Author

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sebvi a couple comments for your to respond to. Thx.

GRIB2_CodeFlag_3_1_CodeTable_en.csv Outdated Show resolved Hide resolved
GRIB2_Template_3_150_GridDefinitionTemplate_en.csv Show resolved Hide resolved
GRIB2_Template_3_150_GridDefinitionTemplate_en.csv Show resolved Hide resolved
GRIB2_CodeFlag_3_12_CodeTable_en.csv Outdated Show resolved Hide resolved
GRIB2_CodeFlag_3_13_FlagTable_en.csv Outdated Show resolved Hide resolved
@amilan17 amilan17 linked an issue Jul 13, 2023 that may be closed by this pull request
New section 3 grid template: The HEALPix grid #197
Closed
@sebvi
Copy link
Contributor

sebvi commented Jul 14, 2023 •
edited
Loading

I still need to add table wide notes, not to specific entry in a table. How is this done?

amilan17
amilan17 commented Jul 17, 2023
View reviewed changes
Copy link
Member Author

@amilan17 amilan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review notes added

@amilan17 amilan17 marked this pull request as draft July 27, 2023 10:23
@amilan17 amilan17 marked this pull request as ready for review August 10, 2023 13:21
@amilan17 amilan17 merged commit 2af9dfc into FT2023-2 Aug 10, 2023
@amilan17 amilan17 deleted the 197-new-section-3-grid-template-the-healpix-grid branch August 10, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebvi sebvi sebvi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New section 3 grid template: The HEALPix grid
2 participants
@amilan17 @sebvi