Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cardinality of GeopositioningMethodType #32

Open
fierz opened this issue Apr 21, 2020 · 11 comments
Open

Cardinality of GeopositioningMethodType #32

fierz opened this issue Apr 21, 2020 · 11 comments
Assignees
Labels
enhancement New feature or request OSCAR/Surface Issue addresses OSCAR/Surface feature WMDS codelist affected

Comments

@fierz
Copy link

fierz commented Apr 21, 2020

Nowadays one is often faced with instruments using more than one GNSS-system to determine the coordinates of a point. Unfortunately, this is not reflected in Table 11-01 (see attached).

I propose to add a general method that could be called GNSS (general)

Screenshot 2020-04-21 at 15 20CEST
Screenshot 2020-04-21 at 15 21CEST

@joergklausen
Copy link
Contributor

Instead of "GNSS (general)", I propose to add "GNSS (multiple)". That way, individual GNSS can still be specified, and the new entry satisfies the requirement in the case where actually several GNSS systems are used.

@fierz
Copy link
Author

fierz commented May 4, 2020

Great, thanks! Adding "GNSS (multiple)" is indeed more appropriate and serves the purpose perfectly.

@KarlBureau
Copy link

I support GNSS (multiple)

@KarlBureau
Copy link

KarlBureau commented May 20, 2020

WMDS_Validation_Report_162_GeopositioningMethod_v0.2.docx
Updated version of Validation report with proposal that multiple (>=1) GeoPositioning Methods be allowed. @joergklausen @toakley76 @fierz

@joergklausen
Copy link
Contributor

I concur with the recommendation in the validation report. Please be aware that this is a CR for the WMDR schema as well as requiring a CR for OSCAR/Surface. I will move the issue over to the WMDR repo.
image

@joergklausen joergklausen transferred this issue from wmo-im/wmds May 20, 2020
@toakley76
Copy link

The proposal to allow more that one method to be selected is acceptable to me, Perhaps GNSS should also be one of the options?

@fierz
Copy link
Author

fierz commented May 20, 2020

Agree the possibility to select one ore more GNS-System may help. Nevertheless, one is faced with situations where this info is not available (I am checking with a colleague whether I could have retrieved that info from the measurements I did). Thus an option with multiple GNS-Systems looks better to me than having to choose 'unknown' or 'inapplicable'.

@toakley76
Copy link

Lets go with both options. Being able to select more than one system and the option of GNSS (multiple).
Sometimes providing the user with an 'easy' option means that they don't check their system information in more detail to see if they have the requested metadata. It is always a balance of getting something, the full details or getting nothing.

@fierz
Copy link
Author

fierz commented May 27, 2020

I could check with my colleague that the instrument I used works with GPS and GLONASS satellites only. More recent instruments will allow to use even more systems, possibly storing the satellites used). In summary, having the two options will be very valuable and I support it.
PS would GNSS (multiple sources) be even a better entry?

@joergklausen joergklausen changed the title 11-01, GeopositioningMethod: missing GNSS (general) Cardinality of GeopositioningMethodType Aug 7, 2020
@joergklausen
Copy link
Contributor

@fierz @toakley76 @KarlBureau Revisiting this issue after a long dormant period, I solicit feedback if the requirement is

  1. include an entry "GNSS (multiple sources)" in the code list
  2. allow more than one entry under geopositioningMethod.
    Option 1 is straight-forward and cheap, option 2 is an easy change in the model, but a much more costly change in any implementation (because the cardinality changes). My recommendation is to go for option 1, unless there are strong arguments for option 2.

@joergklausen joergklausen added enhancement New feature or request OSCAR/Surface Issue addresses OSCAR/Surface feature WMDS codelist affected labels Apr 23, 2021
@fierz
Copy link
Author

fierz commented Apr 23, 2021

Option 2 would have been nice indeed but I am not longer convinced of the added value given the possible implications. I thus would definitely go for option 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request OSCAR/Surface Issue addresses OSCAR/Surface feature WMDS codelist affected
Projects
None yet
Development

No branches or pull requests

4 participants