Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-02 Programs/networks: addition of GOOS/DBCP entries, deadline 24.08.2019 #115

Closed
anthoninlize opened this issue Jul 24, 2019 · 20 comments
Closed
Assignees
Milestone

Comments

@anthoninlize
Copy link
Contributor

anthoninlize commented Jul 24, 2019

Branch
https://github.com/wmo-im/wmds/tree/issue115

proposal
Dear all,

We would need the following new entries:

  • \Co-sponsored\GOOS\DBCP\GDP-ESURFMAR
  • \Co-sponsored\GOOS\DBCP\GDP-MF
  • \Co-sponsored\GOOS\DBCP\COPERNICUS-HRSST-FRM
  • \Co-sponsored\GOOS\DBCP\IPAB-US
  • \Co-sponsored\GOOS\DBCP\SAILDRONE
  • \Co-sponsored\GOOS\DBCP\JAMSTEC-DB
  • \Co-sponsored\GOOS\DBCP\PORTUGAL-MB
  • \Co-sponsored\GOOS\DBCP\SPAIN-IEO-MB

Thank you,
Best

@LuisaIckes LuisaIckes added the Discussion required This issues should be checked and discussed by TT-WMD. label Jul 24, 2019
@LuisaIckes LuisaIckes changed the title 2-02 Programs/networks: addition of GOOS/DBCP entries 2-02 Programs/networks: addition of GOOS/DBCP entries, deadline 24.08.2019 Jul 24, 2019
@joergklausen
Copy link
Contributor

Bearing in mind that @anthoninlize is the designated JCOMMOPS rep in TT-WMD and our best available expert on this, I only checked if these entries do not yet exist (they do not) and are syntactically correct (they are).

We also need the WMO306_CD for these entries. After reviewing what existis already in the table, I propose the following:
\Co-sponsored\GOOS\DBCP\GDP-ESURFMAR: eSurfmarGDP
\Co-sponsored\GOOS\DBCP\GDP-MF: GDPMF
\Co-sponsored\GOOS\DBCP\COPERNICUS-HRSST-FRM: copernicusHRSSTFRM
\Co-sponsored\GOOS\DBCP\IPAB-US: IPABUS
\Co-sponsored\GOOS\DBCP\SAILDRONE: saildrone
\Co-sponsored\GOOS\DBCP\JAMSTEC-DB: JAMSTECDB
\Co-sponsored\GOOS\DBCP\PORTUGAL-MB: PortugalMB
\Co-sponsored\GOOS\DBCP\SPAIN-IEO-MB: SpainIEOMB

There is no consistency for what is written in caps vs small-caps, but the above is in line with what we have now.

I suggest there is no need for a 4-week deadline, this is purely technical.

@LuisaIckes
Copy link
Contributor

From what I understood did we say "technical" are only typo fixes etc., everything that really changes the codelists should not be technical?, but we can adapt the procedure here of course. So I can change the label and deadline. However, it does not really make a difference if we leave 1 or 4 weeks of deadline now - the new release is already out. If this should be part of the release going on the code registry and to the fast track we need another release.

@joergklausen
Copy link
Contributor

joergklausen commented Jul 24, 2019 via email

@LuisaIckes
Copy link
Contributor

@anthoninlize : Is there a description to be added for these entries as well?

@anthoninlize
Copy link
Contributor Author

Yes, for some of them :
\Co-sponsored\GOOS\DBCP\GDP-ESURFMAR: eSurfmarGDP
Global Drifter Program drifters with E-SURFMAR barometer upgrades

\Co-sponsored\GOOS\DBCP\GDP-MF: GDPMF
Global Drifter Program drifters with Meteo-France barometer upgrades

\Co-sponsored\GOOS\DBCP\IPAB-US: IPABUS
International Programme for Antarctic Buoys - US

\Co-sponsored\GOOS\DBCP\JAMSTEC-DB: JAMSTECDB
Japan Agency for Marine-Earth Science and Technology Drifting Buoy

\Co-sponsored\GOOS\DBCP\PORTUGAL-MB: PortugalMB
Portugal - Instituto Hidrografico (IH)

@LuisaIckes
Copy link
Contributor

@anthoninlize : Thank you! I will add N/A for the remaining.

@joergklausen
Copy link
Contributor

This all makes sense and consists of non-controversial additions to an existing table.
@LuisaIckes Please update the files accordingly.
We will implement this in OSCAR/Surface asap.

@LuisaIckes
Copy link
Contributor

The changes are done in issue 115.

@LuisaIckes LuisaIckes removed the Discussion required This issues should be checked and discussed by TT-WMD. label Aug 19, 2019
@amilan17 amilan17 added this to the FT-2021-1 milestone Nov 16, 2020
@amilan17
Copy link
Member

Reopening issue because it was not included in the previous FT cycle.

@joergklausen
Copy link
Contributor

@fstuerzl Verify consistency of branch and follow through

@amilan17 amilan17 removed the FT2021-1 label Dec 17, 2020
@fstuerzl
Copy link
Member

@amilan17, I checked the branch and can confirm that the new entries are consistent with OSCAR.

@joergklausen
Copy link
Contributor

@anthoninlize Please verify entries in branch issue 115 (https://github.com/wmo-im/wmds/blob/issue115/tables_en/2-02.csv) are correct and add definitions where still missing. Deadline: 10 January 2021.

@anthoninlize
Copy link
Contributor Author

@joergklausen I would need a more extended deadline because of the holidays season, and I can't get all the missing descriptions by myself, I need inputs from the team who is on holidays and I won't be able to chat with them before 10 January 2021

I'll add the ones I have already today

@anthoninlize
Copy link
Contributor Author

Attached a copy of the file with new descriptions, when available. I'll provide more later when I can meet the team.
2-02.zip

@fstuerzl
Copy link
Member

Thanks, @anthoninlize, the branch is up to date now. The only descriptions still missing are the ones for "saildrone" and "SpainIEOMB".

@anthoninlize
Copy link
Contributor Author

Great! I've seen other entries with missing descriptions from our side... More than those two ones. We'll update this as soon as possible.

Thanks!

@amilan17
Copy link
Member

fixed conflicts and merged with FT-2021-1-validation branch

@amilan17 amilan17 linked a pull request Jan 20, 2021 that will close this issue
@champikagallage
Copy link

(352) \Co-sponsored\GOOS\DBCP\SAILDRONE
SAILDRONE description: Autonomous Surface Vehicles deployed by NOAA as pilot
(364) \Co-sponsored\GOOS\DBCP\SPAIN-IEO-MB
SPAIN-IEO-MB description: Moored Buoys Managed by Spanish Institute of Oceanography of the Ministry of Science and Technology

@amilan17
Copy link
Member

@fstuerzl - please update branch with new descriptions and tag anna when done

@fstuerzl
Copy link
Member

@amilan17 , @champikagallage branch updated: 7a65dfb

@amilan17 amilan17 removed a link to a pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants