Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-02 Affiliation with programs/networks on "parent level" #214

Closed
fstuerzl opened this issue Dec 15, 2020 · 4 comments
Closed

2-02 Affiliation with programs/networks on "parent level" #214

fstuerzl opened this issue Dec 15, 2020 · 4 comments
Assignees
Labels
branch Discussion required This issues should be checked and discussed by TT-WMD.
Milestone

Comments

@fstuerzl
Copy link
Member

fstuerzl commented Dec 15, 2020

Decision: all parent terms are invalid if standalone

***********

original

The entries in table 2-02 (Programme/network affiliation) are structured with paths. As opposed to variables and methods, this table does not only contain the "endpoints" of the paths, but also every parent entry, even if it is only a collective term. Each of these table entries can theoretically be added to a station as a program or network affiliation.
In the OSCAR application some of the terms are blocked. They are only useful for searching but cannot be added (at least not in the application), as shown in the following figure:  

screenshot_program_affiliation1

Here, in the subcategory "GAW" only the path endpoints can be selected.
This approach is not consistent, since other categories allow also the selection of parent entries, as seen below:  

screenshot_program_affiliation2

For networks this may be reasonable, whereas simple collective terms such as "GAW Contributing networks" or "GOS Other elements" should not be an option for a user to add as a program affiliation and therefore not be a part of the table.

Summary and Purpose
The register "Programme/network affiliation" (table 2-02) contains all path elements not only the "endpoints", which means even unspecific terms can be added as a program affiliation. This is different from the approach in OSCAR.

Proposal
A consistent approach needs to be decided. Possible options are:

  1. All entries on parent level are removed from the table (and blocked in OSCAR).
  2. Some entries on parent level, which should not be added as a program or network affiliation, are removed from the table (and blocked in OSCAR), while others remain.
@fstuerzl fstuerzl added the Discussion required This issues should be checked and discussed by TT-WMD. label Dec 15, 2020
@fstuerzl fstuerzl self-assigned this Dec 15, 2020
@fstuerzl
Copy link
Member Author

fstuerzl commented Jan 7, 2021

Solution, as discussed with WMO (@echarpent, @nunelf): Remove all node entries from code list.
Branch created: https://github.com/wmo-im/wmds/tree/Issue214
View differences: 5f47d73#diff-a066c50c20373fc15bcd759e58529c31867ae12caecaa7d36ad7627f5e689622

@echarpent, @joergklausen, please review the branch.

@joergklausen
Copy link
Contributor

Branch looks good.
@amilan17 Please make sure the GALION entry is included as an entry directly under GAW according to #189.

@amilan17
Copy link
Member

@fstuerzl - as discussed earlier, please remove all "invalid" terms from the table.

@fstuerzl
Copy link
Member Author

@amilan17 invalid terms are removed from this branch

@amilan17 amilan17 linked a pull request Jan 20, 2021 that will close this issue
amilan17 added a commit that referenced this issue Jan 26, 2021
@amilan17 amilan17 removed a link to a pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch Discussion required This issues should be checked and discussed by TT-WMD.
Projects
None yet
Development

No branches or pull requests

3 participants