Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2-02 Programme/network affiliation: Supersede CLIMAT(x) by RBON #382

Closed
fstuerzl opened this issue Feb 22, 2022 · 9 comments · Fixed by #399
Closed

2-02 Programme/network affiliation: Supersede CLIMAT(x) by RBON #382

fstuerzl opened this issue Feb 22, 2022 · 9 comments · Fixed by #399
Assignees
Milestone

Comments

@fstuerzl
Copy link
Member

fstuerzl commented Feb 22, 2022

Proposal Summary

Summary and Purpose

Remove CLIMAT programmes from code table https://codes.wmo.int/wmdr/ProgramAffiliation. Their parent programme "RBCN" is already superseded by "RBON" (see metadata for https://codes.wmo.int/wmdr/ProgramAffiliation/_RBCN), so I suggest to also supersede CLIMAT(C), CLIMAT(CT) and CLIMAT(T) by RBON.
This follows up on issue #215 from FT-2021-1, in which RBCN and RBSN were superseded by RBON. In this issue the "leaves" below RBCN were not changed - probably by mistake. The "leaves" under RBSN, such as e.g. RBSN(p) https://codes.wmo.int/wmdr/ProgramAffiliation/_RBSNp were also superseded by RBON.

This inconsistency should be corrected in the next FT.

Proposal

Supersede CLIMAT(C), CLIMAT(CT) and CLIMAT(T) by RBON.

~9 June 2022

Notation Name Description Supersede by
CLIMATc CLIMAT(C) Station for which monthly climatological means of surface elements are transmitted RBON
CLIMATct CLIMAT(CT) Station for which monthly climatological means of both surface and upper- air elements are transmitted
CLIMATt CLIMAT(T) Station for which monthly climatological means of upper-air elements are transmitted

Reason

Correction of a mistake or inconsistency

Stakeholder(s)

@echarpent

Consultations

Context

#215

Expected Impact of Change

HIGH (for deprecated and superseded codes)

The migration of RBCN affiliations to RBON in OSCAR is already in development, so the effort to deal with this issue in OSCAR is not HIGH...

@fstuerzl fstuerzl changed the title enter table # and brief summary 2-02 Programme/network affiliation: Supersede CLIMAT(x) by RBON Feb 22, 2022
@fstuerzl fstuerzl self-assigned this Feb 22, 2022
@fstuerzl fstuerzl added this to the FT2022-2 milestone Apr 5, 2022
@fstuerzl fstuerzl assigned amilan17 and unassigned fstuerzl Apr 5, 2022
@echarpent
Copy link

I agree to remove CLIMAT programmes from the code table provided that we make it sure not to loose information in OSCAR/Surface for observing stations that were affiliated to them. In particular, (i) the corresponding observations in OSCAR/Surface ought to be associated to Climate Monitoring application area, and (ii) some information must be provided also in OSCAR/Surface that monthly climate summaries are normally made available.

@joergklausen
Copy link
Contributor

@echarpent The WMDS code tables are used in OSCAR/Surface but our TT-WIGOSMD has no influence on that. If the removal of CLIMAT from the code lists is conditional on any implementation issues in OSCAR/Surface, then this needs to be cleared up first. For TT-WIGOSMD, we need a 'yes': CLIMAT can disappear, or a 'no': CLIMAT must remain as a child of xxx (and the XXX needs to be specified).

@echarpent
Copy link

For consistency with what we did with RBSN and RBCN, I suggest to drop CLIMAT from the code list. We'll find a way to deal with this outside of the scope of TT-WIGOSMD

@fstuerzl
Copy link
Member Author

CLIMATc/t/ct were removed from table 2-02 (7c2caf8) and included in the superseded file (f4b7578).

@joergklausen, @gaochen-larc, please review the branch.

@joergklausen
Copy link
Contributor

Thank you @fstuerzl, I am fine with these commits.

@gaochen-larc
Copy link
Contributor

I reviewed the branch and agree with your changes @fstuerzl. Thank you!!!

amilan17 added a commit that referenced this issue May 17, 2022
@amilan17
Copy link
Member

@fstuerzl - please review new branch.

@fstuerzl
Copy link
Member Author

@amilan17, the new branch is correct.

@amilan17 amilan17 linked a pull request May 31, 2022 that will close this issue
@amilan17
Copy link
Member

amilan17 commented Jun 9, 2022

ready for FT

@amilan17 amilan17 closed this as completed Jun 9, 2022
@amilan17 amilan17 moved this to Issue is ready for FT approval procedure in Codelist Amendments for WMDR Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants