Externalise ts-lint rules #112
Conversation
| "check-typecast" | ||
| ] | ||
| } | ||
| "extends": ["tslint-react", "tslint-create-react-app-typescript"] |
There was a problem hiding this comment.
To be honest i'd be happier to just extend from tslint-react and let people write their own rules? Would be interested to hear how people are actually using this file, whether they just delete their own and start again, or leave as-is.
There was a problem hiding this comment.
That would make things a lot simpler
There was a problem hiding this comment.
Sample tslint-react config suggests extending tslint:latest
The latest preset extends tslint:recommended and adds features supported by tslint 2.4
Many reasonable defaults
Quite strict
Helps keep consistent style across projects
Angular contributors have an issue and a pull request considering its usage in their bootstrapping tools
There was a problem hiding this comment.
I would agree this is a good starting point!
There was a problem hiding this comment.
I like having all the tslint config rules that someone else thought through, but some of the rules are out of date.
Project is a day or so old, here's my tslint: https://github.com/Falieson/typescript-react-asteroid-meteor/blob/master/client/tslint.json
|
@timjacobi do you want to update this? |
|
I need to check with my new employer. Shouldn't be a problem though but will take a day or two. Happy to update once greenlit. |
|
Ok great! If you can't work on this, then i'm sure someone else will be able to 👍 |
|
Are you able to continue on this PR @timjacobi? If not i don't mind helping out. Sounds like from the thoughts above we would provide something like |
|
@ianschmitz are you interested in picking this up? Closing for now. |
As discussed in #109
I wasn't entirely sure how to properly test my changes since the setup doesn't allow it to test with
npm link. Please let me know. Thanks :)