This repository was archived by the owner on Jan 26, 2019. It is now read-only.
Travis build/e2e-kitchensink: Outstanding behavior fixes... #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorianGrey
force-pushed
the
another-travis-fix-attempt
branch
2 times, most recently
from
3d7e9cd to
5207cfc
Compare
DorianGrey
changed the title
DorianGrey
force-pushed
the
another-travis-fix-attempt
branch
2 times, most recently
from
0346af7 to
85270a9
Compare
DorianGrey
force-pushed
the
another-travis-fix-attempt
branch
from
85270a9 to
7df0674
Compare
DorianGrey
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just another attempt...
Current problem: the
e2e-kitchensinktask fails on testing theejectcommand, sincebabel-loaderdoes not seem to be installed after ejection, even though the log mentions that it was added properly.This might have something to do with a mix of
npm runandyarn... but I'm still inspecting this further.€dit:
Workaround seems to be to force ayarn installbefore building ...yay.Next error to solve:Module not found: Error: Can't resolve 'absoluteLoad' in '/tmp/tmp.ji4bCBWZ7D/test-kitchensink/src/features/env'.€dit#2:
Next error to fix:TypeError: (0 , _testIntegrity.version) is not a functionraised insrc/features/webpack/LinkedModules.test.jsThere is a module namedtest-integritywhich gets linked during the test. However, it does not seem to be in the expected format. Attempting to useyarninstead ofnpmto link it results in amodule not founderror.€dit#3:
Seems that the dependency installation for the ejected projected has to happend before the
npm linkfortest-integrity- otherwise, an outdated version is installed which does not match the one expected in the test. After having this pointed out, the updated suite seems to work fine - finally!