Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Past events details #277

Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

Past events details #277

wants to merge 34 commits into from

Conversation

fatmahussein
Copy link
Collaborator

  • Update the current past events details page to match the new figma design
  • Desktop Version:
deskview

Mobile Version:

mobiview

@fatmahussein
assets used in the this section
8156b96
@fatmahussein
Events Calendar Component
0c85dc1
@fatmahussein
Modify meetup page to match figma design
2ec79ac
@fatmahussein
Remove unnecessary comments
131a1c8
@fatmahussein
Modified to match new design
a55eb09
@fatmahussein
Delete unused files
490dc36
@fatmahussein
Styling for the calendar component
2b94203
@fatmahussein
Update link styles as per the design
492fd4c
@fatmahussein
Update stylings fro the meetup page
d0a6bd5
@fatmahussein
Add links to the fullcalendar libraries
6d3588c
@fatmahussein
Add dependencies required by the calendar
bef9009
@fatmahussein
fix linter errors
62c36fa
@fatmahussein
Merge branch 'main' into 263-events-page
19d37b4
@fatmahussein
Use the Button component for uniformity of the buttons used
88b56aa
@fatmahussein
Update the button stylings
a0a096c
@fatmahussein
Merge branch '263-events-page' of https://github.com/wnbrb/wnb-rb-site …
faa7864 
…into 263-events-page
@fatmahussein
update node version
54b014f
@fatmahussein
update node v
c92e9e7
@fatmahussein
yarn install
3b281e4
@fatmahussein
update the past events details to match figma
d9a0a10
@fatmahussein
update css to match figma
d856c3d
@fatmahussein
remove unused dependencies
92eec29
@fatmahussein
asset used in this section
fdd7741
@fatmahussein
update styles to match figma design
746f0f3
@fatmahussein fatmahussein linked an issue Feb 27, 2025 that may be closed by this pull request
Past Event Details #270
Open
sarah-fflow
sarah-fflow reviewed Mar 7, 2025
View reviewed changes
app/javascript/stylesheets/meetup.scss
.video-section{
background-color: #fff099;
}
.video-container{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With apologies for nit-picking, white space needs empty line between css selectors, and space before the opening brace, so it should be:

}

.video-section {

... but not a reason to hold this PR, just a request to please keep white space tidy in future PRs

sarah-fflow
sarah-fflow reviewed Mar 7, 2025
View reviewed changes
app/javascript/stylesheets/meetup.scss
@@ -146,3 +147,51 @@ li {
font-family: besley;
color: wheat !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: still 3 !important in this file, as before, they can keep for a future PR

sarah-fflow
sarah-fflow reviewed Mar 10, 2025
View reviewed changes
yarn.lock Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest don't commit yarn changes with this PR, unless they are related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-fflow sarah-fflow sarah-fflow left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Past Event Details
2 participants
@fatmahussein @sarah-fflow