WIP: client: use standard port when setting SSL/TLS #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #105.
TODO:
Client.DailWithContext()
an error is potentially lost when using fallback. I have to look into appending or logging the error somehow;TLSPolicy
is actually alreadyTLSMandatory
. However, the default port is 25. I left this unchanged as it would break package consumers depending on these defaults. Perhaps this can be better updated for the next major release?A preliminary code review on this PR would be appreciated. And if you have suggestions for item 2, it would be welcome.