Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to skip adding a User-Agent #178

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

gegorov2030
Copy link
Contributor

Adds an option to omit the default User-Agent, suitable for scenarios like SMTP proxies where headers are conditionally passed based on receipt.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.45%. Comparing base (68e6284) to head (299490f).

Files Patch % Lines
msg.go 42.85% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
- Coverage   81.29%   75.45%   -5.85%     
==========================================
  Files          24       24              
  Lines        2128     2135       +7     
==========================================
- Hits         1730     1611     -119     
- Misses        283      417     +134     
+ Partials      115      107       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wneessen
Copy link
Owner

Thanks for the PR @gegorov2030. Can you please add a test for this as well? Besides that, LGTM.

@gegorov2030
Copy link
Contributor Author

Added, thank you

@wneessen wneessen merged commit 5c143cb into wneessen:main Feb 26, 2024
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants