chore: Update libraries #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheus23
commented
Sep 4, 2023
Comment on lines
-107
to
-111
| writer | ||
| .write_header() | ||
| .await | ||
| .map_err(|e| Error::CarFileError(anyhow!(e)))?; | ||
|
|
There was a problem hiding this comment.
This is done implicitly by iroh-car once the first block is written.
I just removed this since it makes tracking the bytes_written easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently a new
iroh-carwas released with a bunch of my PRs (n0-computer/iroh-car#12 and n0-computer/iroh-car#11) got merged. This makes some stuff easier in here for us.This PR resolves some things we can make easier now due to that.
Needs #30 to be merged first.