Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bytes-based public file writing API #376

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

matheus23
Copy link
Member

@matheus23 matheus23 commented Nov 30, 2023

Previously we only had a CID-based API that just "set" the file CID to some value.

This now requires public files to encode their content as byte arrays.

Now the public and private APIs are very similar, both operate on the byte-array level for files.

Made possible through #375

TODO:

  • Update Wasm bindings

@matheus23 matheus23 self-assigned this Nov 30, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@ce292b5). Click here to learn what that means.
The diff coverage is 57.40%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #376   +/-   ##
=======================================
  Coverage        ?   53.86%           
=======================================
  Files           ?       55           
  Lines           ?     3891           
  Branches        ?      954           
=======================================
  Hits            ?     2096           
  Misses          ?     1182           
  Partials        ?      613           
Files Coverage Δ
wnfs-common/src/async_serialize.rs 33.33% <ø> (ø)
wnfs-unixfs-file/src/balanced_tree.rs 80.48% <ø> (ø)
wnfs-unixfs-file/src/builder.rs 51.85% <ø> (ø)
wnfs-unixfs-file/src/chunker.rs 10.00% <100.00%> (ø)
wnfs-unixfs-file/src/chunker/fixed.rs 62.50% <100.00%> (ø)
wnfs-unixfs-file/src/types.rs 43.85% <ø> (ø)
wnfs/src/private/directory.rs 68.92% <ø> (ø)
wnfs/src/private/file.rs 73.68% <100.00%> (ø)
wnfs-unixfs-file/src/chunker/rabin.rs 0.00% <0.00%> (ø)
wnfs-unixfs-file/src/unixfs.rs 27.23% <0.00%> (ø)
... and 8 more

@matheus23 matheus23 marked this pull request as ready for review December 1, 2023 11:42
@matheus23 matheus23 requested a review from a team as a code owner December 1, 2023 11:42
@matheus23 matheus23 merged commit 2b67800 into main Dec 5, 2023
10 checks passed
@matheus23 matheus23 deleted the matheus23/write-public-file-bytes-api branch December 5, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant