-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Preliminary RootTree
APIs
#390
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Fix nameaccumulator lib not working when the "rug" features is on, but "num-bigint-dig" is off. - Avoid `.unwrap()` in `AccessKey`.
matheus23
changed the title
feat: Preliminary
feat: Preliminary Jan 2, 2024
RootTree
APIs.RootTree
APIs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #390 +/- ##
==========================================
- Coverage 54.57% 54.35% -0.22%
==========================================
Files 57 57
Lines 3956 4003 +47
Branches 963 980 +17
==========================================
+ Hits 2159 2176 +17
- Misses 1175 1191 +16
- Partials 622 636 +14
|
It's not yet documented/finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these two PRs:
wnfs-unixfs-file
crate for encoding big byte arrays in IPLD #375it's now possible to have a single root API for both the public and private file system!
This implements it.
RootTree
APIwnfs-nameaccumulator
when thenum-bigint-dig
feature is disabled.unwrap()
inAccessKey
APIs and make serializing/deserializing fallibleprintln!
s that got left over from debugging