Skip to content

Commit

Permalink
fix logrotate empty file hole issue
Browse files Browse the repository at this point in the history
refer to ossrs#1554
  • Loading branch information
maguoliang committed Jan 6, 2020
1 parent b5f4b96 commit 8b20b36
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
15 changes: 15 additions & 0 deletions trunk/etc/logrotate.d/srs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
/data/log/srs/*.log {

weekly

size 200M

copytruncate

rotate 5

dateext

noolddir

}
2 changes: 1 addition & 1 deletion trunk/src/app/srs_app_log.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ void SrsFastLog::open_log_file()

if(fd == -1 && errno == ENOENT) {
fd = open(filename.c_str(),
O_RDWR | O_CREAT | O_TRUNC,
O_RDWR | O_CREAT | O_TRUNC | O_APPEND/*logrotate copytruncate need this flag*/,
S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH
);
}
Expand Down

0 comments on commit 8b20b36

Please sign in to comment.