Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash on Python 2 when reusing environments #450

Merged
merged 4 commits into from
Jun 12, 2021
Merged

Fix crash on Python 2 when reusing environments #450

merged 4 commits into from
Jun 12, 2021

Commits on Jun 12, 2021

  1. Remove redundant mock in test for environment reuse 

    This breaks tests comparing a string from pyvenv.cfg to command output, because
the latter will be a mock. There is no inherent need for this mock. It was added
recently, and probably speculatively or for performance reasons.
    @cjolowicz
    cjolowicz committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    09faec1 View commit details
    Browse the repository at this point in the history

  2. Add test case for reusing Python 2 environments

    @cjolowicz
    cjolowicz committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    ed432af View commit details
    Browse the repository at this point in the history

  3. Read base prefix from pyvenv.cfg if present

    @cjolowicz
    cjolowicz committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    683c29c View commit details
    Browse the repository at this point in the history

  4. Remove trailing newline when querying interpreter base prefix

    @cjolowicz
    cjolowicz committed Jun 12, 2021
    Configuration menu
    Copy the full SHA
    1cedae7 View commit details
    Browse the repository at this point in the history