-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Python 3.10.0-rc.2 coverage fix #479
Conversation
Agreed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🚀
Thanks for the help as always! |
Closes #478
After some playing around with my fork I've managed to get tests and coverage playing nicely on 3.10.
Summary of changes:
cover
with the same pythons astests
so I could accesssession.python
to do the abovecover-<version
> in the Github Actions workflow (session.notify
didn't seem to work for me here, I tried both"cover"
and"cover-<version>"
as arguments with no luck, if anyone knows how to fix this it would clean this solution up a little bit)I did also notice that one of the tests (
test_session_completer
) was coupled to the noxfile. I didn't look into it too much but I think we should look at decoupling if possible as then we're free to change the noxfile however we want without altering test behaviour