Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Python 3.10.0-rc.2 coverage fix #479

Merged
merged 8 commits into from
Sep 16, 2021
Merged

CI: Python 3.10.0-rc.2 coverage fix #479

merged 8 commits into from
Sep 16, 2021

Conversation

FollowTheProcess
Copy link
Collaborator

@FollowTheProcess FollowTheProcess commented Sep 16, 2021

Closes #478

After some playing around with my fork I've managed to get tests and coverage playing nicely on 3.10.

Summary of changes:

  • Detect when we're running on 3.10 and reduce coverage fail under to 99 from 100
  • Parametrise cover with the same pythons as tests so I could access session.python to do the above
  • Explicitly call cover-<version> in the Github Actions workflow (session.notify didn't seem to work for me here, I tried both "cover" and "cover-<version>" as arguments with no luck, if anyone knows how to fix this it would clean this solution up a little bit)

I did also notice that one of the tests (test_session_completer) was coupled to the noxfile. I didn't look into it too much but I think we should look at decoupling if possible as then we're free to change the noxfile however we want without altering test behaviour

@FollowTheProcess FollowTheProcess added the ci Issues relating to nox's CI pipeline label Sep 16, 2021
noxfile.py Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@cjolowicz
Copy link
Collaborator

I did also notice that one of the tests (test_session_completer) was coupled to the noxfile. I didn't look into it too much but I think we should look at decoupling if possible as then we're free to change the noxfile however we want without altering test behaviour

Agreed 👍

Copy link
Collaborator

@cjolowicz cjolowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@FollowTheProcess FollowTheProcess merged commit f584aed into wntrblm:main Sep 16, 2021
@FollowTheProcess FollowTheProcess deleted the 310rc2-fix branch September 16, 2021 07:56
@FollowTheProcess
Copy link
Collaborator Author

Thanks 🚀

Thanks for the help as always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues relating to nox's CI pipeline
Development

Successfully merging this pull request may close these issues.

Coverage failure on 3.10.0-rc.2
2 participants