Use shutil.rmtree over shelling out to rm -rf in noxfile #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking through the older issues to try and find the low hanging fruit to close off and found #298.
This PR addresses point 1:
I did some digging around points 2 and 3, it would seem that point 2 at least has been resolved anyway (see here).
Point 3 I'm not too sure and I don't have access to a Windows machine to easily test but since we build the official project docs in an ubuntu image on CI I don't see a major issue here?
Unrelated, but I also noticed that on my machine (macos, python 3.10) running bare
nox
results in ugly looking failures because it tries to runconda-tests
and I don't have conda installed. A simple switch should fix this:I'll raise that in a separate issue/PR though to keep things clean 👍🏻