Pin virtualenv version in lint session #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great you tracked this down! I was just going to suggest adding this the VIRTUALENV_SETUPTOOLS: "!=59.4.0"But this is also good. |
Happy to change to that if we want? |
cjolowicz
approved these changes
Dec 28, 2021
gaborbernat
reviewed
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #545
virtualenv today released 20.11.0 which internally bumps the embedded version of setuptools from 58.3.0 to 59.4.0, which must have contained some breaking change for pre-commit as it depends on virtualenv>=20.0.8 so it would have pulled this latest version in
Pinning virtualenv to 20.10.0 inside the lint session has fixed the issue