Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use latest GHA runners and include macOS #613

Merged
merged 3 commits into from
May 4, 2022
Merged

ci: Use latest GHA runners and include macOS #613

merged 3 commits into from
May 4, 2022

Conversation

FollowTheProcess
Copy link
Collaborator

This PR bumps the GHA runners to the -latest versions. The versions can be found on the GitHub actions docs here but a brief summary of the changes is:

  • Ubuntu: No change, latest uses 20.04 already
  • Windows: Windows 2019 to Windows 2022
  • macOS: New runner, macos-latest uses macOS Big Sur 11

There was a new failing test on Windows python3.7 testing the reuse of a python2.7 environment failing with an io on closed file error, I've simply skipped it if on Windows as it's passing everywhere else and ofc python2.7 is deprecated

@FollowTheProcess FollowTheProcess added the ci Issues relating to nox's CI pipeline label May 2, 2022
@FollowTheProcess
Copy link
Collaborator Author

FollowTheProcess commented May 2, 2022

Ahh, if we want to merge this we will have to update the list of required workflows for the repo as it's currently waiting for ubuntu-20.04 and windows-2019 which of course no longer exist. AFAIK members don't have the perms to do this, cc @theacodes 🙂

Related to #604

@FollowTheProcess FollowTheProcess linked an issue May 3, 2022 that may be closed by this pull request
Copy link
Collaborator

@DiddiLeija DiddiLeija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're just blocked by the "required checks" issue. Excluding that, this sounds perfect to me 👍

@theacodes theacodes merged commit b73b190 into main May 4, 2022
@theacodes theacodes deleted the ci/macos branch May 4, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues relating to nox's CI pipeline
Development

Successfully merging this pull request may close these issues.

Should we make all test CI sessions required?
3 participants