chore: switch to hatchling #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofek, I just swapped from |
|
henryiii
commented
Oct 8, 2022
|
The pyproject.toml formatter is insisting the comment be removed. |
henryiii
commented
Oct 8, 2022
|
Nice, looks like this is basically ready to go? |
|
Yes, except for the issue with pyproject.fmt not allowing a comment. |
|
Looks like the recent fail is just adding an extra newline? If we fix that then I'm happy to merge this 👍🏻 |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
force-pushed
the
henryiii/chore/hatchling
branch
from
63acab7
to
b30043f
Compare
FollowTheProcess
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick examples of moving to hatchling. Slightly less config, 2 seconds faster, less verbose build messages,
reduced chance of version conflicts, and slightly cleaner output. Other packages using hatchling include pipx, black, tox4, etc.Just thought I'd throw it out there. Current system is completely fine too. Mostly making the PR since I tried it out and already had it. One benefit of PEP 621 is that it's easy to switch to the best performing backend. :)
PS: It occurred to me on the version conflicts (some packages limit setuptools < 60), that you don't have hatchling or setuptools when you have a wheel, so that should never be a problem. This is very much just a developer choice.
From #655.