Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to hatchling #659

Merged
merged 5 commits into from
Nov 23, 2022

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Oct 8, 2022

Quick examples of moving to hatchling. Slightly less config, 2 seconds faster, less verbose build messages, reduced chance of version conflicts, and slightly cleaner output. Other packages using hatchling include pipx, black, tox4, etc.

Just thought I'd throw it out there. Current system is completely fine too. Mostly making the PR since I tried it out and already had it. One benefit of PEP 621 is that it's easy to switch to the best performing backend. :)

PS: It occurred to me on the version conflicts (some packages limit setuptools < 60), that you don't have hatchling or setuptools when you have a wheel, so that should never be a problem. This is very much just a developer choice.

From #655.

@henryiii
Copy link
Collaborator Author

henryiii commented Oct 8, 2022

@ofek, I just swapped from setuptools to hatchling, and the tox_to_nox extra (which is declared that way and used that way) is getting normalized to tox-to-nox, which causes it to silently start failing. I don't see any way to provide a backward compatible tox_to_nox extra. AFAICT, this is more likely Pip's issue, since PEP 685 was accepted? I see no mention there of PEP 685 support.

@henryiii henryiii marked this pull request as draft October 8, 2022 13:50
@ofek
Copy link

ofek commented Oct 8, 2022

@ofek
Copy link

ofek commented Oct 8, 2022

Other packages using hatchling

See https://hatch.pypa.io/dev/users/

pyproject.toml Outdated Show resolved Hide resolved
@henryiii
Copy link
Collaborator Author

henryiii commented Oct 8, 2022

The pyproject.toml formatter is insisting the comment be removed.

@ofek
Copy link

ofek commented Oct 8, 2022

tox-dev/pyproject-fmt#16

pyproject.toml Outdated Show resolved Hide resolved
@FollowTheProcess
Copy link
Collaborator

Nice, looks like this is basically ready to go?

@henryiii
Copy link
Collaborator Author

Yes, except for the issue with pyproject.fmt not allowing a comment.

@FollowTheProcess
Copy link
Collaborator

FollowTheProcess commented Oct 20, 2022

image

Looks like the recent fail is just adding an extra newline? If we fix that then I'm happy to merge this 👍🏻

henryiii and others added 5 commits November 23, 2022 12:52
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@FollowTheProcess FollowTheProcess marked this pull request as ready for review November 23, 2022 18:08
Copy link
Collaborator

@FollowTheProcess FollowTheProcess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉 Thanks @henryiii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2022.11.21: pep517 build do not isntall nox/tox_to_nox.jinja2
3 participants