Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tests to pass in environments where NO_COLOR=1 is set #777

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Allow tests to pass in environments where NO_COLOR=1 is set #777

merged 1 commit into from
Feb 21, 2024

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Feb 21, 2024 •
edited
Loading

Closes #708

@edgarrmondragon @mgorny
Allow tests to pass in environments where NO_COLOR=1 is set
4befcf8 
Co-authored-by: Michał Górny <mgorny@gentoo.org>
@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 21, 2024 05:50
FollowTheProcess
FollowTheProcess approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@FollowTheProcess FollowTheProcess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@FollowTheProcess FollowTheProcess merged commit ddea973 into wntrblm:main Feb 21, 2024
40 checks passed
@edgarrmondragon edgarrmondragon deleted the 708-env-color-tests branch February 21, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FollowTheProcess FollowTheProcess FollowTheProcess approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests fail when NO_COLOR=1 is set in the environment
2 participants
@edgarrmondragon @FollowTheProcess