Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support noxfile being a symlink #829

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented May 19, 2024

Fix #828.

If you need the non-symlinked file, it's easy to get with __file__, as can be seen in the tests.

@henryiii henryiii marked this pull request as draft May 19, 2024 04:11
nox/tasks.py Outdated Show resolved Hide resolved
@jamesharris-garmin
Copy link

I actually use the existing behavior (see #828 (comment)) but I can probably work around a change if this is more natural. I'll follow this so I know if this comes in and breaks me.

@henryiii henryiii force-pushed the henryiii/fix/symlinknox branch from 27302d5 to 4a5a190 Compare October 18, 2024 07:46
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/symlinknox branch 2 times, most recently from 82c6152 to 41dde93 Compare November 1, 2024 22:33
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii henryiii force-pushed the henryiii/fix/symlinknox branch from 41dde93 to b4aa701 Compare November 1, 2024 22:42
@henryiii henryiii marked this pull request as ready for review November 1, 2024 23:33
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@henryiii
Copy link
Collaborator Author

Going to get it in for the next version; as seen in the tests, you can work around the change if you need the old behavior using __file__.

@henryiii henryiii merged commit 2c43214 into wntrblm:main Nov 11, 2024
24 checks passed
@henryiii henryiii deleted the henryiii/fix/symlinknox branch November 11, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Wrong starting directory when noxfile.py is a symlink
2 participants