-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helper to get the Python listing #877
Conversation
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, just some nitpicks about naming
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
I was surprised that |
The idea is that you would have to guess the upper bound ( https://discuss.python.org/t/requires-python-upper-limits/12663), so one method (classifiers) doesn't have an upper bound, and the other requires it. Though it could be split if you have good ideas for names. |
Makes sense. Another approach would be to always look at Trove classifiers first, and fall back to |
That's exactly what I originally tried, actually, but then I would have had to implement filtering, and why would you ever want to filter the classifiers using this parameter? What would be more likely to happen is someone would forget to update this bound when adding the classifier. Also, having it be "auto" means you'd have to pick what to do if classifiers and requires-python didn't match. |
Hi! |
That's not a valid classifier. All valid classifiers are here: https://pypi.org/classifiers/ And the plan would be to add something like pypa/trove-classifiers#195, not a 3.13t classifier. |
You can add to this list or process it, though. Including adding PyPy, etc. |
Close #855.